Move PHPCS and VIPCS into their own file and only run when PHP files have changed. Also only run PHPCS on changed lines of PHP files, not the entire file

Author: dkotter

.github/workflows/eslint.yml

@@ -45,63 +45,3 @@ jobs:
         elif [[ "${{ github.event_name }}" == "push" ]]; then
           npm run lint:js
         fi
-
-  phpcs:
-    name: phpcs
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: Set standard cache directories
-      run: |
-        composer config -g cache-dir "${{ env.COMPOSER_CACHE }}"
-
-    - name: Prepare composer cache
-      uses: actions/cache@v4
-      with:
-        path: ${{ env.COMPOSER_CACHE }}
-        key: composer-${{ env.COMPOSER_VERSION }}-${{ hashFiles('**/composer.lock') }}
-        restore-keys: |
-          composer-${{ env.COMPOSER_VERSION }}-
-
-    - name: Set PHP version
-      uses: shivammathur/setup-php@v2
-      with:
-        php-version: '7.4'
-        coverage: none
-        tools: composer:v2
-
-    - name: Install dependencies
-      run: composer install
-
-    - name: Get updated PHP files
-      id: changed-files
-      uses: tj-actions/changed-files@v45
-      with:
-        files: |
-          **/*.php
-
-    - name: PHPCS check
-      run: |
-        if [[ "${{ steps.changed-files.outputs.any_changed }}" == 'true' && "${{ github.event_name }}" == "pull_request" ]]; then
-          ./vendor/bin/phpcs ${{ steps.changed-files.outputs.all_changed_files }} -s --runtime-set testVersion 7.4-
-        elif [[ "${{ github.event_name }}" == "push" ]]; then
-          ./vendor/bin/phpcs . -s --runtime-set testVersion 7.4-
-        fi
-
-  vipcs:
-    name: vipcs
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: VIPCS check
-      uses: 10up/wpcs-action@stable
-      with:
-        enable_warnings: true
-        standard: 'WordPress-VIP-Go'
-        excludes: 'tests'

.github/workflows/lint.yml

@@ -0,0 +1,68 @@
+name: PHP Linting
+
+on:
+  push:
+    branches:
+      - develop
+      - trunk
+    paths:
+      - "**.php"
+  pull_request:
+    branches:
+      - develop
+    paths:
+      - "**.php"
+
+jobs:
+  phpcs:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup proper PHP version
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 7.4
+
+      - name: Get composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Cache dependencies
+        uses: actions/cache@v4
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+
+      - name: Get changed files
+        id: changed-files
+        uses: tj-actions/changed-files@v45
+        with:
+          files: |
+            **/*.php
+
+      - name: Install dependencies
+        run: composer install --prefer-dist
+
+      - name: Run PHP_CodeSniffer
+        run: |
+          HEAD_REF=$(git rev-parse HEAD)
+          git checkout $HEAD_REF
+          ./vendor/bin/phpcs-changed -s --git --git-base origin/${{ github.base_ref }} ${{ steps.changed-files.outputs.all_changed_files }}
+
+  vipcs:
+    name: vipcs
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v4
+
+    - name: VIPCS check
+      uses: 10up/wpcs-action@stable
+      with:
+        enable_warnings: true
+        standard: 'WordPress-VIP-Go'
+        excludes: 'tests'

.github/workflows/phpcs.yml

@@ -33,7 +33,8 @@
     "phpstan/extension-installer": "1.4.x-dev",
     "php-stubs/wp-cli-stubs": "dev-master",
     "johnbillion/wp-compat": "dev-trunk",
-    "phpstan/phpstan-deprecation-rules": "1.2.x-dev"
+    "phpstan/phpstan-deprecation-rules": "1.2.x-dev",
+    "sirbrillig/phpcs-changed": "^2.11"
   },
   "scripts": {
     "lint": "phpcs -s . --runtime-set testVersion 7.4-",