Merge pull request #690 from 10up/fix/645

Remove Subscriber from the list of allowed roles

Author: dkotter

includes/Classifai/Features/Feature.php

@@ -75,6 +75,9 @@ public function setup_roles() {
 		$this->roles      = get_editable_roles() ?? [];
 		$this->roles      = array_combine( array_keys( $this->roles ), array_column( $this->roles, 'name' ) );
 
+		// Remove subscriber from the list of roles.
+		unset( $this->roles['subscriber'] );
+
 		/**
 		 * Filter the allowed WordPress roles for a feature.
 		 *

tests/cypress/integration/admin/common-feature-fields.test.js

@@ -18,13 +18,7 @@ describe('Common Feature Fields', () => {
 		feature_pdf_to_text_generation: 'PDF Text Extraction',
 	};
 
-	const allowedRoles = [
-		'administrator',
-		'editor',
-		'author',
-		'contributor',
-		'subscriber',
-	];
+	const allowedRoles = [ 'administrator', 'editor', 'author', 'contributor' ];
 
 	Object.keys( features ).forEach( ( feature ) => {
 		it( `"${ features[ feature ] }" feature common fields`, () => {
@@ -51,7 +45,7 @@ describe('Common Feature Fields', () => {
 			for ( const role of allowedRoles ) {
 				if (
 					'feature_image_generation' === feature &&
-					( 'contributor' === role || 'subscriber' === role )
+					'contributor' === role
 				) {
 					continue;
 				}