Skip to content

Commit b98cff0

Browse files
committed
suggestions implemented
1 parent 3e72034 commit b98cff0

File tree

4 files changed

+9
-24
lines changed

4 files changed

+9
-24
lines changed

includes/Classifai/Features/ImageGeneration.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ public function print_media_templates() {
274274
$settings = $this->get_settings();
275275
$provider_id = $settings['provider'];
276276
$number_of_images = absint( $settings[ $provider_id ]['number_of_images'] );
277-
$per_image_settings = isset( $settings[ $provider_id ]['per_image_settings'] ) ? $settings[ $provider_id ]['per_image_settings'] : false;
277+
$per_image_settings = $settings[ $provider_id ]['per_image_settings'] ?? false;
278278
$provider_instance = $this->get_feature_provider_instance( $provider_id );
279279
?>
280280

@@ -304,7 +304,7 @@ public function print_media_templates() {
304304
<br>
305305
<input type="checkbox" id="view-additional-image-generation-settings" />
306306
<label id="view-additional-image-generation-settings-label" for="view-additional-image-generation-settings">
307-
<?php esc_html_e( 'View Additional Settings', 'classifai' ); ?>
307+
<?php esc_html_e( 'Additional settings', 'classifai' ); ?>
308308
</label>
309309
<div class="additional-image-generation-settings hidden">
310310
<label>

includes/Classifai/Providers/OpenAI/DallE.php

-16
Original file line numberDiff line numberDiff line change
@@ -148,22 +148,6 @@ public function render_provider_fields() {
148148
'class' => 'classifai-provider-field hidden provider-scope-' . static::ID,
149149
]
150150
);
151-
152-
add_settings_field(
153-
static::ID . '_per_image_settings',
154-
esc_html__( 'Enable per-image settings for quality, size, and style', 'classifai' ),
155-
[ $this, 'render_input' ],
156-
$this->feature_instance->get_option_name(),
157-
$this->feature_instance->get_option_name() . '_section',
158-
[
159-
'option_index' => static::ID,
160-
'label_for' => 'per_image_settings',
161-
'input_type' => 'checkbox',
162-
'default_value' => $settings['per_image_settings'] ?? false,
163-
'description' => __( 'Enable this to allow users to select the quality, size, and style of the generated image.', 'classifai' ),
164-
'class' => 'classifai-user-based-opt-out',
165-
]
166-
);
167151
}
168152

169153
/**

src/js/features/image-generation/media-modal/views/prompt.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,23 @@ const Prompt = wp.media.View.extend( {
3838
let quality = '';
3939
let size = '';
4040
let style = '';
41+
let parent = event.target.parentElement;
4142

4243
if ( event.which === 13 ) {
4344
prompt = event.target.value.trim();
4445
} else if ( event.target.nodeName === 'BUTTON' ) {
45-
prompt = event.target.parentElement
46+
prompt = parent
4647
.querySelector( '.prompt' )
4748
.value.trim();
48-
quality = event.target.parentElement
49+
quality = parent
4950
.querySelector( '.quality' )
5051
.value.trim();
5152

52-
size = event.target.parentElement
53+
size = parent
5354
.querySelector( '.size' )
5455
.value.trim();
5556

56-
style = event.target.parentElement
57+
style = parent
5758
.querySelector( '.style' )
5859
.value.trim();
5960
}

src/js/settings/components/provider-settings/openai-dalle.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ export const OpenAIDallESettings = ( { isConfigured = false } ) => {
159159
/>
160160
</SettingsRow>
161161
<SettingsRow
162-
label={ __( 'Enable per-image settings', 'classifai' ) }
162+
label={ __( 'Per-image settings', 'classifai' ) }
163163
description={ __(
164-
'Enable this to allow users to select the quality, size, and style of the generated image.',
164+
'If enabled, allows users to select the quality, size, and style when generating an image.',
165165
'classifai'
166166
) }
167167
>

0 commit comments

Comments
 (0)