Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image processing > Descriptive text generator > Upload image > Labels and buttons are not aligned in line. #704

Closed
1 task done
QAharshalkadu opened this issue Feb 9, 2024 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@QAharshalkadu
Copy link

QAharshalkadu commented Feb 9, 2024

Describe the bug

Image processing > Descriptive text generator > Upload image > Labels and buttons are not aligned in line.

The labels ie. Descriptive text, Image tags, smart thumbnail,s and buttons generate, and regenerate should be aligned in line

Steps to Reproduce

1 Add/edit post
2. add image block
3. upload image > select image
4. RHS > Attachments details section scroll to the bottom
5. Check fields label and buttons

Screenshots, screen recording, code snippet

https://prnt.sc/DOky_Walf3lv
https://prnt.sc/YSuKQP5qnm75

Environment information

Local

WordPress information

WordPress 6.4.3

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added the help wanted Extra attention is needed label Feb 9, 2024
@dkotter dkotter added this to the Future Release milestone Feb 9, 2024
@jeffpaul jeffpaul moved this to Backlog in Open Source Practice Feb 9, 2024
@jamespstyles
Copy link

I'll try take a look at this one @jeffpaul

@jamespstyles jamespstyles self-assigned this Jul 31, 2024
@jamespstyles
Copy link

@QAharshalkadu @jeffpaul @dkotter, I'm not sure if we will want to make adjustments here. I believe the fields are rendering correctly. At wider screen widths the buttons all align.

wider width

On narrower widths the longer labels "Descriptive text" and "Smart thumbnail" cause the buttons to wrap underneath. This is consistent with the regular fields: note the alignment on the "Alternative Text" textarea input shown below.

narrower with wrapping

However perhaps consistency with the regular fields isn't essential and adding some custom css to improve/tidy up these fields and to make them visually different may even be desirable. For example currently it not necessarily apparent that these fields are associated with Classifai's functionality - just a thought.

@dkotter
Copy link
Collaborator

dkotter commented Aug 5, 2024

Thanks for looking into this! I personally think that what we have is fine and works as well as it can within the current UI. I'd suggest we just close this out

@jeffpaul jeffpaul closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Open Source Practice Aug 5, 2024
@jeffpaul jeffpaul removed this from the Future Release milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

4 participants