Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX on playing audio files #14

Open
jeffpaul opened this issue Nov 13, 2021 · 2 comments
Open

Improve UX on playing audio files #14

jeffpaul opened this issue Nov 13, 2021 · 2 comments
Labels
help wanted Extra attention is needed type:enhancement New feature or request.

Comments

@jeffpaul
Copy link
Member

Is your enhancement related to a problem? Please describe.
From @dkotter in #6:

Some weirdness between the audio blocks and the WebAmp player, where if you click the start button on the Audio block it seems to start the player instead (which may be fine) and if you remove an Audio block, it sometimes starts playing the next song in the player

Describe the solution you'd like
Review the work in #6, the current state of the develop branch, and what approach should (if any) be taken to resolve this issue.

Designs

Describe alternatives you've considered

Additional context

@jeffpaul jeffpaul added type:enhancement New feature or request. help wanted Extra attention is needed labels Nov 13, 2021
@jeffpaul jeffpaul modified the milestones: Future Release, 1.1.0 Nov 13, 2021
@Sidsector9 Sidsector9 modified the milestones: 1.1.0, 1.2.0 Jun 21, 2022
@jeffpaul jeffpaul modified the milestones: 1.2.0, Future Release Jul 19, 2022
@iansvo
Copy link
Contributor

iansvo commented Nov 2, 2022

@jeffpaul So far I've been unable to replicate the issue described. I've broken down what I tested and the results below:

Steps

  1. Add Winamp Block to a page
  2. Add multiple audio files from the media library
  3. Attempt to play back the audio file from the regular audio block
  4. Attempt to play back the audio file from the player preview
  5. Remove an audio block and see if the audio starts playing
  6. Remove songs via the player and confirm they don't actually modify the block children

Other notes/thoughts

  • I would think that clicking the play button on the audio block should play the audio file in question, which is the behavior I'm seeing.
  • Playing one audio file from the Block view doesn't autoplay to the next audio file (which I imagine is the intended result)

From here I'll need more detailed replication steps or I won't be able to really do much more with this. So far everything appears to be working as intended based on my tests.

@jeffpaul
Copy link
Member Author

jeffpaul commented Nov 3, 2022

@dkotter any recollection of more specific errors/steps from this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants