Skip to content

Commit 40c6c85

Browse files
committed
Merge bitcoin#27192: util: add missing include and fix function signature
8847ce4 util: add missing include and fix function signature (Cory Fields) Pull request description: ping hebasto Discovered while testing pre-compiled header support with CMake: https://github.com/theuni/bitcoin/commits/cmake-pch-poc. Compilation of that branch fails without this fix and succeeds with it. Similar to the fix in bitcoin#27144. The problem of having a default argument in the definition was masked by the missing include. Using PCH forces that include, so we end up with the compiler error we should've been getting all along. ACKs for top commit: fanquake: ACK 8847ce4 Tree-SHA512: 5eb9a6691ee37cbc5033a48aedcbf5c93af3b234614ae14c3fcc858f1ee505f630ad68f8bbb69ffa280080c8d0f91451362cb3819290b741ce906b2b3224a622
2 parents 236cd23 + 8847ce4 commit 40c6c85

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/util/readwritefile.cpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// Distributed under the MIT software license, see the accompanying
44
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
55

6+
#include <util/readwritefile.h>
7+
68
#include <fs.h>
79

810
#include <algorithm>
@@ -11,7 +13,7 @@
1113
#include <string>
1214
#include <utility>
1315

14-
std::pair<bool,std::string> ReadBinaryFile(const fs::path &filename, size_t maxsize=std::numeric_limits<size_t>::max())
16+
std::pair<bool,std::string> ReadBinaryFile(const fs::path &filename, size_t maxsize)
1517
{
1618
FILE *f = fsbridge::fopen(filename, "rb");
1719
if (f == nullptr)

0 commit comments

Comments
 (0)