Manual completion option

Command completions (e.g. for 'open' commands) were previously automatically
updated when command characters are being typed. This commit adds a boolean
option 'manualcompletion' that makes the completions update only when Tab key
is pressed.

Resolves #379.

Author: Ape

README.md

@@ -63,6 +63,7 @@ These extensions do a wonderful job of adding Vim-like keybindings to Google Chr
 | sortlinkhints                       | boolean                            | Sort link hint lettering by the link's distance from the top-left corner of the page      | false                                                                       |
 | localconfig                         | boolean                            | Read the cVimrc config from `configpath` (when this is set, you connot save from cVim's options page | false                                                            |
 | completeonopen                      | boolean                            | Automatically show a list of command completions when the command bar is opened           | false                                                                       |
+| manualcompletion                    | boolean                            | Wait for Tab key instead of automatically showing command completions (e.g. with 'open')  | false                                                                       |
 | configpath                          | string                             | Read the cVimrc from this local file when configpath is set                               | ""                                                                          |
 | changelog                           | boolean                            | Auto open the changelog when cVim is updated                                              | true                                                                        |
 | completionengines                   | array of strings                   | use only the specified search engines                                                     | ["google", "duckduckgo", "wikipedia", "amazon"]                             |

background_scripts/options.js

@@ -55,6 +55,7 @@ var defaultSettings = {
   changelog: true,
   localconfig: false,
   completeonopen: false,
+  manualcompletion: false,
   scrollduration: 500,
   zoomfactor: 0.10,
   configpath: '',

content_scripts/command.js

@@ -45,6 +45,7 @@ Command.dataElements = [];
 Command.matches = [];
 Command.customCommands = {};
 Command.lastInputValue = '';
+Command.completionsNeedUpdate = false;
 
 Command.setupFrameElements = function() {
   this.bar = document.createElement('div');
@@ -181,8 +182,17 @@ Command.completionOrder = {
 };
 
 Command.updateCompletions = function(useStyles) {
+  if (settings.manualcompletion) {
+    this.completionsNeedUpdate = true;
+  } else {
+    this.executeCompletionUpdate(useStyles);
+  }
+};
+
+Command.executeCompletionUpdate = function(useStyles) {
   if (!window.isCommandFrame)
     return;
+  this.completionsNeedUpdate = false;
   this.completionResults = [];
   this.dataElements = [];
   this.data.innerHTML = '';

content_scripts/keys.js

@@ -387,8 +387,12 @@ var KeyHandler = {
       case '<S-Tab>':
         if (Command.type === 'action') {
           event.preventDefault();
-          Mappings.actions[ (key === '<Tab>' ? 'next' : 'previous') +
-                            'CompletionResult' ]();
+          if (Command.completionsNeedUpdate) {
+            Command.executeCompletionUpdate(true);
+          } else {
+            Mappings.actions[ (key === '<Tab>' ? 'next' : 'previous') +
+                              'CompletionResult' ]();
+          }
         }
         break;
       case '<C-p>':

pages/mappings.html

@@ -241,6 +241,12 @@ <h3 id="cvimrc">cVimrc</h3>
 <td style="text-align:right">false</td>
 </tr>
 <tr>
+<td>manualcompletion</td>
+<td>boolean</td>
+<td>Wait for Tab key instead of automatically showing command completions (e.g. with 'open')</td>
+<td style="text-align:right">false</td>
+</tr>
+<tr>
 <td>configpath</td>
 <td>string</td>
 <td>Read the cVimrc from this local file when configpath is set</td>
@@ -1406,4 +1412,4 @@ <h1 id="contributing">Contributing</h1>
 <li>Click on &quot;Load Unpacked Extension...&quot;</li>
 <li>Select the cVim directory.</li>
 </ol>
-</html>
+</html>