Skip to content

Add option to select completion results by <Up>/<Down> #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option to select completion results by <Up>/<Down> #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ These extensions do a wonderful job of adding Vim-like keybindings to Google Chr
| dimhintcharacters | boolean | dim letter matches in hint characters rather than remove them from the hint | true |
| defaultnewtabpage | boolean | use the default chrome://newtab page instead of a blank page | false |
| cncpcompletion | boolean | use `<C-n>` and `<C-p>` to cycle through completion results (requires you to set the nextCompletionResult keybinding in the chrome://extensions page (bottom right) | false |
| updowncompletion | boolean | use `<Up>` and `<Down>` to cycle through completion results | false |
| smartcase | boolean | case-insensitive find mode searches except when input contains a capital letter | true |
| incsearch | boolean | begin auto-highlighting find mode matches when input length is greater thant two characters | true |
| typelinkhints | boolean | (numerichints required) type text in the link to narrow down numeric hints | false |
Expand Down
1 change: 1 addition & 0 deletions background_scripts/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ var defaultSettings = {
ignorecase: true,
numerichints: false,
cncpcompletion: false,
updowncompletion: false,
smartcase: true,
incsearch: true,
autohidecursor: false,
Expand Down
9 changes: 7 additions & 2 deletions content_scripts/keys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,8 +762,13 @@ var KeyHandler = {
return;
case '<Up>': // Command history navigation/search
case '<Down>':
event.preventDefault();
Command.history.cycle(Command.type, (key === '<Up>'));
if (Command.type === 'action' && settings.updowncompletion) {
event.preventDefault();
Mappings.actions[ (key === '<Up>' ? 'previous' : 'next') + 'CompletionResult' ]();
} else {
event.preventDefault();
Command.history.cycle(Command.type, (key === '<Up>'));
}
break;
case '<Enter>':
case '<C-Enter>':
Expand Down