Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECDH: Handler with customizable output length #426

Closed
wants to merge 1 commit into from
Closed

ECDH: Handler with customizable output length #426

wants to merge 1 commit into from

Conversation

matthiasgeihs
Copy link

This PR proposes to add an additional argument to sharedSecretFromKeyAgreement that allows to control the shares secret output length. This is useful, for example, if one wants to use SHA-512 as the hash function instead of SHA-256. Resolves #425.

@what-the-diff
Copy link

what-the-diff bot commented Sep 9, 2023

PR Summary

  • Flexible Output Length in Key Agreement
    The method for generating a shared secret key in complex cryptographic computations (ECDH) now allows for varying its length according to users' needs. Previously it was set at 32 units, but now it defaults to 32 and can be varied as per the requirement.

  • Testing for the Updated Key Agreement Method
    To ensure the correct functioning of this updated method in ECDH, new test cases have been added. These tests check the functionality under various circumstances, including the use of a custom hash handler, different output lengths, and processing of additional data.

@csjones
Copy link
Contributor

csjones commented Sep 10, 2023

Hey @matthiasgeihs

First off, thank you for your contribution and suggesting these changes. I posted a reply in the issue thread for this pull request. Given that the KeyAgreement APIs wouldn't need modification to support your use case, do you have any other additional specific details that are not being addressed?

@csjones
Copy link
Contributor

csjones commented Sep 11, 2023

Closing: #425 (comment)

@csjones csjones closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test/Example for sharedSecretFromKeyAgreement with handler?
2 participants
@matthiasgeihs @csjones