Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use semver for release tags #478

Closed
metalurgical opened this issue Jan 15, 2024 · 1 comment
Closed

Please use semver for release tags #478

metalurgical opened this issue Jan 15, 2024 · 1 comment
Labels
❌ invalid This doesn't seem right

Comments

@metalurgical
Copy link

Swift Package Manager expects SemVer versioning.

https://developer.apple.com/documentation/xcode/publishing-a-swift-package-with-xcode#Tag-your-latest-commit

Currently there are a number of breaking changes in previously released versions which is making it very difficult to find compatible versions of this library between different libraries using this one as a dependency. This is due to .exact() being used instead of from: for this library to avoid the breaking changes.

If you look at 0.10.0, there is a breaking change at 0.12.1, thereafter there is another breaking change leading up to 0.15.0.

@csjones
Copy link
Contributor

csjones commented Jan 15, 2024

Hey @metalurgical 👋

Thanks for raising your concern. In response to your message, it's important to note that using a major version of 0 in Semantic Versioning (SemVer) is valid and indicates the software is in its initial development phase. During this phase, breaking changes are expected with minor version increments (as seen in your 0.y.z versions).

My approach aligns with SemVer principles, where the API is not considered stable until reaching version 1.0.0. The link you posted references the Semantic Versioning spec which states the following:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

Additionally, this repository's readme includes a similar notice. https://github.com/GigaBitcoin/secp256k1.swift?tab=readme-ov-file#danger

If you have any further concerns or believe there's more to address, feel free to leave a comment. 🙂

@csjones csjones closed this as completed Jan 15, 2024
@csjones csjones added 🚫 wontfix This will not be worked on ❌ invalid This doesn't seem right and removed 🚫 wontfix This will not be worked on labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants