Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VisionOS #489

Closed
ismyhc opened this issue Jan 26, 2024 · 4 comments · Fixed by #491
Closed

Add support for VisionOS #489

ismyhc opened this issue Jan 26, 2024 · 4 comments · Fixed by #491
Labels
🔏 enhancement New feature or request

Comments

@ismyhc
Copy link

ismyhc commented Jan 26, 2024

Im not exactly sure how hard this would be, but curious if adding support for VisionOS platform would be possible?

Of course I can use VisionOS (Made for iPad) target, but you lose the native look and feel of the platform by doing so.

@csjones
Copy link
Contributor

csjones commented Jan 26, 2024

Hey @ismyhc 👋

Thanks for opening an issue, this is totally possible. I just created a PR, #491, let me know if this works for you or if any additional changes might be needed. 😁

@csjones csjones added the 🔏 enhancement New feature or request label Jan 26, 2024
@csjones csjones linked a pull request Jan 26, 2024 that will close this issue
@ismyhc
Copy link
Author

ismyhc commented Jan 26, 2024

Hey @ismyhc 👋

Thanks for opening an issue, this is totally possible. I just created a PR, #491, let me know if this works for you or if any additional changes might be needed. 😁

Awesome!

So, I think it's working as expected, but something to note. And this happens on main branch too, when I add the package via package manager, it also adds zkp.

When I try and build, it get 70 duplicate errors. If I remove zkp framework it builds.

Screenshot 2024-01-26 at 4 54 06 PM

Screenshot 2024-01-26 at 4 54 34 PM

@csjones
Copy link
Contributor

csjones commented Jan 26, 2024

Just created a new release including the change https://github.com/GigaBitcoin/secp256k1.swift/releases/tag/0.16.0

The 70 duplicate errors you're encountering are expected. This is because the secp256k1 and zkp libraries published by this package are essentially identical. Essentially, libsecp256k1 has a base version and an experimental version. The experimental version is almost the same as the base version but includes additional features not yet ready for Bitcoin.

If you found any of this helpful, I would greatly appreciate it if you could star this repo 😁

@ismyhc
Copy link
Author

ismyhc commented Jan 26, 2024

Just created a new release including the change https://github.com/GigaBitcoin/secp256k1.swift/releases/tag/0.16.0

The 70 duplicate errors you're encountering are expected. This is because the secp256k1 and zkp libraries published by this package are essentially identical. Essentially, libsecp256k1 has a base version and an experimental version. The experimental version is almost the same as the base version but includes additional features not yet ready for Bitcoin.

If you found any of this helpful, I would greatly appreciate it if you could star this repo 😁

Awesome! Thanks for the quick turnaround. Star coming up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔏 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants