-
Notifications
You must be signed in to change notification settings - Fork 238
Support for QoS = 1 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for your suggestions. Actually, QoS1 can be achived without any extra storage when the ack is immediately checked by waiting for it. (This is what the Paho and lwmqtt library do). In anycase V2 (#59) will support QoS 1 and 2. Some earlier discussion can be found here #49. I'll close this as it is a duplicate and already taken care of. |
Is anyone working on this? If not, I could look into it. |
Yes, I'm just finishing the PR. I plan to release V2 this week. :) In the meantime your are welcome to test the branch in your project. The API is fixed and the code stable. I'm just clearing up some docs. |
Awesome. 👍 👍 👍 🥇 |
So which branch is it? I can only see -master in this repo. |
I merged V2 yesterday. You can use master or wait until the library manager has been updated. |
I think it would make a lot of sense to support QoS 1 in this client - from my understanding of the protocol, it would require:
I think a good starting point would be retaining 10 last packet ids by default. Once a packet is confirmed, it is removed from the set.
Further refinements could add an exponential delay mechanism for retransmissions, etc.
Did I miss anything?
The text was updated successfully, but these errors were encountered: