New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`cleanname` has a 1-char OOB write when input is `""` #686

Open

noncombatant opened this issue Nov 1, 2024 · 0 comments

noncombatant commented Nov 1, 2024 •

edited

Loading

It's at line 50:

plan9port/src/lib9/cleanname.c

Line 50 in 61e362a

*q = '\0';

. There isn't necessarily a second byte to write into. Detected with ASAN.

Unfortunately, I think this means the API has to change (to explicitly ignore or reject blank strings): blank strings can't be cleaned to ".".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment