33902 Update dina-base to 0.125 (#390)

Updated dina-base and use the proper method in baseDAO

Author: cgendreau

pom.xml

@@ -45,7 +45,7 @@
 
     <asciidoctor-maven-plugin.version>2.1.0</asciidoctor-maven-plugin.version>
     <asciidoctorj.diagram.version>2.0.2</asciidoctorj.diagram.version>
-    <dina-base-api.version>0.124</dina-base-api.version>
+    <dina-base-api.version>0.125</dina-base-api.version>
 
     <postgresql.version>42.4.4</postgresql.version>
 

src/main/java/ca/gc/aafc/objectstore/api/service/ObjectOrphanRemovalService.java

@@ -67,12 +67,8 @@ private List<ObjectUpload> findOrphans() {
       "LEFT JOIN " + Derivative.class.getCanonicalName() + " d ON ou.fileIdentifier = d.fileIdentifier " +
       "WHERE m.fileIdentifier IS NULL AND d.fileIdentifier IS NULL";
 
-    return baseDAO.resultListFromQuery(
-        ObjectUpload.class,
-        sql,
-        0,
-        MAX_ORPHAN_QUERY_LIMIT,
-        null);
+    return baseDAO.findAllByQuery(ObjectUpload.class, sql, null,
+      MAX_ORPHAN_QUERY_LIMIT, 0);
   }
 
   private boolean isExpired(ObjectUpload upload) {