Skip to content

Commit 4d40911

Browse files
authored
Merge pull request #2376 from dweindl/release_0.23.1
Release 0.23.1
2 parents 815a50d + 81ec111 commit 4d40911

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
## v0.X Series
44

5+
### v0.23.1 (2024-03-11)
6+
7+
* Fixes installation issues related to building SuiteSparse on some systems
8+
by @dweindl in https://github.com/AMICI-dev/AMICI/pull/2375
9+
510
### v0.23.0 (2024-03-07)
611

712
**Features**

python/sdist/setup.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ def get_extensions():
4141
# Used by all extensions
4242
global_cmake_configure_options = [
4343
"-DCMAKE_VERBOSE_MAKEFILE=ON",
44+
f"-DCMAKE_MODULE_PATH={prefix_path.as_posix()}",
4445
]
4546

4647
# SuiteSparse Config
@@ -51,6 +52,7 @@ def get_extensions():
5152
cmake_configure_options=[
5253
*global_cmake_configure_options,
5354
"-DCMAKE_POSITION_INDEPENDENT_CODE=ON",
55+
"-DBUILD_SHARED_LIBS=OFF",
5456
# Building SuiteSparse_config does not require a BLAS
5557
# we just set BLAS_LIBRARIES to skip the search,
5658
# the value is not used
@@ -68,6 +70,8 @@ def get_extensions():
6870
source_dir="amici/ThirdParty/SuiteSparse/AMD",
6971
cmake_configure_options=[
7072
*global_cmake_configure_options,
73+
"-DBUILD_SHARED_LIBS=OFF",
74+
"-DCMAKE_POSITION_INDEPENDENT_CODE=ON",
7175
"-DSUITESPARSE_USE_FORTRAN=OFF",
7276
],
7377
)
@@ -79,6 +83,8 @@ def get_extensions():
7983
cmake_configure_options=[
8084
*global_cmake_configure_options,
8185
"-DSUITESPARSE_USE_FORTRAN=OFF",
86+
"-DBUILD_SHARED_LIBS=OFF",
87+
"-DCMAKE_POSITION_INDEPENDENT_CODE=ON",
8288
],
8389
)
8490
# SuiteSparse COLAMD
@@ -89,6 +95,8 @@ def get_extensions():
8995
cmake_configure_options=[
9096
*global_cmake_configure_options,
9197
"-DSUITESPARSE_USE_FORTRAN=OFF",
98+
"-DBUILD_SHARED_LIBS=OFF",
99+
"-DCMAKE_POSITION_INDEPENDENT_CODE=ON",
92100
],
93101
)
94102
# SuiteSparse KLU
@@ -101,6 +109,8 @@ def get_extensions():
101109
"-DKLU_USE_CHOLMOD=OFF",
102110
"-DSUITESPARSE_USE_CUDA=OFF",
103111
"-DSUITESPARSE_USE_FORTRAN=OFF",
112+
"-DBUILD_SHARED_LIBS=OFF",
113+
"-DCMAKE_POSITION_INDEPENDENT_CODE=ON",
104114
],
105115
)
106116
# SUNDIALS

version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.23.0
1+
0.23.1

0 commit comments

Comments
 (0)