Support builds for Electron v32 (WiseLibs#1226)

* use c++20 required by v8

* adjust macro and method signatures

* replace SetAccessor with SetNativeDataProperty

* use old signatures for older node version

* install g++ 10 on ubuntu

Author: neoxpert

.github/workflows/build.yml

@@ -48,6 +48,11 @@ jobs:
         run: brew install python-setuptools
       - if: ${{ !startsWith(matrix.os, 'windows') && !startsWith(matrix.os, 'macos') }}
         run: python3 -m pip install setuptools
+      - if: ${{ startsWith(matrix.os, 'ubuntu') }}
+        run: |
+          sudo apt update
+          sudo apt install gcc-10 g++-10 -y
+          sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100 --slave /usr/bin/g++ g++ /usr/bin/g++-10 --slave /usr/bin/gcov gcov /usr/bin/gcov-10
       - run: npm install --ignore-scripts
       - run: npm run build-debug
       - run: npm test
@@ -101,6 +106,11 @@ jobs:
         run: brew install python-setuptools
       - if: ${{ !startsWith(matrix.os, 'windows') && !startsWith(matrix.os, 'macos') }}
         run: python3 -m pip install setuptools
+      - if: ${{ startsWith(matrix.os, 'ubuntu') }}
+        run: |
+          sudo apt update
+          sudo apt install gcc-10 g++-10 -y
+          sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100 --slave /usr/bin/g++ g++ /usr/bin/g++-10 --slave /usr/bin/gcov gcov /usr/bin/gcov-10
       - run: npm install --ignore-scripts
       - run: ${{ env.NODE_BUILD_CMD }} -u ${{ secrets.GITHUB_TOKEN }}
       - run: ${{ env.ELECTRON_BUILD_CMD }} -u ${{ secrets.GITHUB_TOKEN }}

binding.gyp

@@ -9,14 +9,14 @@
       'target_name': 'better_sqlite3',
       'dependencies': ['deps/sqlite3.gyp:sqlite3'],
       'sources': ['src/better_sqlite3.cpp'],
-      'cflags_cc': ['-std=c++17'],
+      'cflags_cc': ['-std=c++20'],
       'xcode_settings': {
-        'OTHER_CPLUSPLUSFLAGS': ['-std=c++17', '-stdlib=libc++'],
+        'OTHER_CPLUSPLUSFLAGS': ['-std=c++20', '-stdlib=libc++'],
       },
       'msvs_settings': {
         'VCCLCompilerTool': {
           'AdditionalOptions': [
-            '/std:c++17',
+            '/std:c++20',
           ],
         },
       },

src/better_sqlite3.cpp

@@ -1,7 +1,11 @@
 #define NODE_ARGUMENTS const v8::FunctionCallbackInfo<v8::Value>&
 #define NODE_ARGUMENTS_POINTER const v8::FunctionCallbackInfo<v8::Value>*
 #define NODE_METHOD(name) static void name(NODE_ARGUMENTS info)
+#if defined NODE_MODULE_VERSION && NODE_MODULE_VERSION < 121
 #define NODE_GETTER(name) static void name(v8::Local<v8::String> _, const v8::PropertyCallbackInfo<v8::Value>& info)
+#else
+#define NODE_GETTER(name) static void name(v8::Local<v8::Name> _, const v8::PropertyCallbackInfo<v8::Value>& info)
+#endif
 #define INIT(name) static v8::Local<v8::Function> name(v8::Isolate* isolate, v8::Local<v8::External> data)
 
 #define EasyIsolate v8::Isolate* isolate = v8::Isolate::GetCurrent()
@@ -143,7 +147,7 @@ void SetPrototypeGetter(
 	v8::Local<v8::External> data,
 	v8::Local<v8::FunctionTemplate> recv,
 	const char* name,
-	v8::AccessorGetterCallback func
+	v8::AccessorNameGetterCallback func
 );
 #end
 #src
@@ -152,7 +156,7 @@ void SetPrototypeGetter(
 	v8::Local<v8::External> data,
 	v8::Local<v8::FunctionTemplate> recv,
 	const char* name,
-	v8::AccessorGetterCallback func
+	v8::AccessorNameGetterCallback func
 ) {
 	v8::HandleScope scope(isolate);
 
@@ -166,7 +170,7 @@ void SetPrototypeGetter(
 		v8::PropertyAttribute::None
 	);
 	#else
-	recv->InstanceTemplate()->SetAccessor(
+	recv->InstanceTemplate()->SetNativeDataProperty(
 		InternalizedFromLatin1(isolate, name),
 		func,
 		0,