internal/metrics: Use constant for unknown result type

metalmatze · metalmatze · commit 70584111ccae · 2025-07-18T16:40:41.000+02:00
diff --git a/internal/metrics/dns.go b/internal/metrics/dns.go
@@ -13,6 +13,7 @@ const (
 	ResultSafeBrowsing = "safe_browsing"
 	ResultSafeSearch   = "safe_search"
 	ResultParental     = "parental"
+	ResultUnknown      = "unknown"
 )
 
 // DNSQueries tracks DNS queries by their processing result
diff --git a/internal/stats/unit.go b/internal/stats/unit.go
@@ -345,7 +345,7 @@ func (u *unit) add(e *Entry) {
 	case RParental:
 		resultLabel = metrics.ResultParental
 	default:
-		resultLabel = "unknown"
+		resultLabel = metrics.ResultUnknown
 	}
 	metrics.IncrementDNSQueryByResult(resultLabel)
 	metrics.ObserveDNSResponseTime(resultLabel, e.ProcessingTime)

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ const (`
`13`	`13`	`ResultSafeBrowsing = "safe_browsing"`
`14`	`14`	`ResultSafeSearch = "safe_search"`
`15`	`15`	`ResultParental = "parental"`
	`16`	`+ ResultUnknown = "unknown"`
`16`	`17`	`)`
`17`	`18`
`18`	`19`	`// DNSQueries tracks DNS queries by their processing result`
Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ func (u unit) add(e Entry) {`
`345`	`345`	`case RParental:`
`346`	`346`	`resultLabel = metrics.ResultParental`
`347`	`347`	`default:`
`348`		`- resultLabel = "unknown"`
	`348`	`+ resultLabel = metrics.ResultUnknown`
`349`	`349`	`}`
`350`	`350`	`metrics.IncrementDNSQueryByResult(resultLabel)`
`351`	`351`	`metrics.ObserveDNSResponseTime(resultLabel, e.ProcessingTime)`