Merge pull request #456 from Adnuntius/jp_test_base_backup_some_test_not_executed_for_gt_96

due to a dodgy version comparison some of the base backup tests were …

Author: rdunklau

test/test_basebackup.py

@@ -9,6 +9,7 @@
 import tarfile
 import time
 from copy import deepcopy
+from distutils.version import LooseVersion
 from queue import Queue
 from subprocess import check_call
 
@@ -367,17 +368,17 @@ def test_basebackups_local_tar_with_delta_stats(self, capsys, db, pghoard, tmpdi
         self._test_basebackups(capsys, db, pghoard, tmpdir, BaseBackupMode.local_tar_delta_stats)
 
     def test_basebackups_local_tar_nonexclusive(self, capsys, db, pghoard, tmpdir):
-        if db.pgver < "9.6":
+        if LooseVersion(db.pgver) < "9.6":
             pytest.skip("PostgreSQL 9.6+ required for non-exclusive backups")
         self._test_basebackups(capsys, db, pghoard, tmpdir, BaseBackupMode.local_tar)
 
     def test_basebackups_local_tar_legacy(self, capsys, db, pghoard, tmpdir):
-        if db.pgver >= "9.6":
+        if LooseVersion(db.pgver) >= "9.6":
             pytest.skip("PostgreSQL < 9.6 required for exclusive backup tests")
         self._test_basebackups(capsys, db, pghoard, tmpdir, BaseBackupMode.local_tar)
 
     def test_basebackups_local_tar_exclusive_conflict(self, capsys, db, pghoard, tmpdir):
-        if db.pgver >= "9.6":
+        if LooseVersion(db.pgver) >= "9.6":
             pytest.skip("PostgreSQL < 9.6 required for exclusive backup tests")
         need_stop = False
         try:
@@ -409,7 +410,7 @@ def test_basebackups_local_tar_pgespresso(self, capsys, db, pghoard, tmpdir):
                 cursor.execute("DROP EXTENSION pgespresso")
 
     def test_basebackups_replica_local_tar_nonexclusive(self, capsys, recovery_db, pghoard, tmpdir):
-        if recovery_db.pgver < "9.6":
+        if LooseVersion(recovery_db.pgver) < "9.6":
             pytest.skip("PostgreSQL 9.6+ required for non-exclusive backups")
         self._test_basebackups(capsys, recovery_db, pghoard, tmpdir, BaseBackupMode.local_tar, replica=True)