Glo: only initialzes AB geometry helper up to lowest allowed layer#14721
Merged
f3sch merged 1 commit intoAliceO2Group:devfrom Oct 6, 2025
Merged
Glo: only initialzes AB geometry helper up to lowest allowed layer#14721f3sch merged 1 commit intoAliceO2Group:devfrom
f3sch merged 1 commit intoAliceO2Group:devfrom
Conversation
We can skip initializing the layers below the lowest allowed AB layer. This allows to run the AB for ITS3 otherwise the initialization of the RecoGeomHelper is not well defined and crashed for layers < 3 since the chip mapping is not well defined. Currently we anyways allow AB tracks only to go down to layer 3 by default and this might not change for Run 4 anytime soon. If it does the RecoGeomHelper class has to be adapted then. Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
shahor02
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can skip initializing the layers below the lowest allowed AB layer. This allows to run the AB for ITS3 otherwise the initialization of the RecoGeomHelper is not well defined and crashes for layers < 3 since the chip mapping is not well defined.
Currently we anyways allow AB tracks only to go down to layer 3 by default and this might not change for Run 4 anytime soon. If it does the RecoGeomHelper class has to be adapted then.