enable parallel world in anchored simulation#1786
enable parallel world in anchored simulation#1786maciacco wants to merge 40 commits intoAliceO2Group:masterfrom
Conversation
maciacco
requested review from
benedikt-voelkel,
chiarazampolli and
sawenzel
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
| parser.add_argument("-tf", type=int, help="number of timeframes per job", default=1) | ||
| parser.add_argument("--ccdb-IRate", type=bool, help="whether to try fetching IRate from CCDB/CTP", default=True) | ||
| parser.add_argument("--trig-eff", type=float, dest="trig_eff", help="Trigger eff needed for IR", default=-1.0) | ||
| parser.add_argument("-enable-parallel-world", type=int, dest="enable_parallel_world", help="Enable parallel geometry", default=0) |
There was a problem hiding this comment.
This should not be needed. We can already pass simulation config key values from the outside.
There was a problem hiding this comment.
Thanks for your review, I removed this in the latest commit
sawenzel
left a comment
sawenzel
left a comment
There was a problem hiding this comment.
In principle, we can pass config key values from the outside using the -confKey of o2dpg_sim_workflow.py;
Before doing bigger changes such as in this PR, could you please check if this works or what are the show-stoppers with such approach?
|
@sawenzel thanks for your comment, I modified the implementation by forwarding the parallel world configuration to o2dpg_sim_workflow.py as you suggested. This gives the same results as before in the workflow creation |
MC/run/ANCHOR/anchorMC.sh
Outdated
| remainingargs="-seed ${SEED} -ns ${NSIGEVENTS} --include-local-qc --pregenCollContext" | ||
| remainingargs="${remainingargs} -e ${ALIEN_JDL_SIMENGINE} -j ${NWORKERS}" | ||
| remainingargs="${remainingargs} -productionTag ${ALIEN_JDL_LPMPRODUCTIONTAG:-alibi_anchorTest_tmp}" | ||
| remainingargs="${remainingargs} -confKey \"GeometryManagerParam.useParallelWorld=${ENABLE_PARALLEL_WORLD};GeometryManagerParam.usePwGeoBVH=${ENABLE_PARALLEL_WORLD};GeometryManagerParam.usePwCaching=${ENABLE_PARALLEL_WORLD}\"" |
There was a problem hiding this comment.
this is not ideal. Someone might give -confKey from the outside ... and this will override the external choice of parameters.
| if [ ! "${CCDB_RC}" == "0" ]; then | ||
| echo_error "Problem during CCDB prefetching of ${CCDBOBJECTS_IDEAL_MC}. Exiting." | ||
| exit ${CCDB_RC} | ||
| if [ "${ENABLE_PARALLEL_WORLD}" == "0" ]; then |
There was a problem hiding this comment.
could you please explain a bit what these changes are doing/achieving?
|
Hi all, |
…#1760) * Allow to generate events for event-pool usage (no vertex applied + kinematic merging) * Example script demonstrating simple event pool creation and reading events from pool https://its.cern.ch/jira/browse/O2-5216
* HF Cocktail: rap range as in Run2 * LF Cocktail: update decaytable
* PWGLF: Change Xi/Om spectra for injection
Script which helps to determine the complete list of commits so that a given commit can be cherry-picked without problems.
…p#1780) * Set default firstOrbit to 256 just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC. * Better SOR determination Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2.
* DPMJET and other new processes * Changing suffix since this is not a normal ini file for o2sim
* Adding Upsilon Generator * fixing ini fil bug * Fix the test --------- Co-authored-by: Lucamicheletti93 <[email protected]>
Co-authored-by: Laura Serksnyte <[email protected]>
* Disable dpmjet process and add few Tau processes * Adjusting paths to use
* remove lines which inhibit transport at large eta * fix Pythia generator ambiguity
* fix typo * fix typo 2 * fix typo 3
* Created EPOS4 external example generator * Updated center-of-mass energy of EPOS4 example * Implemented GeneratorEPOS4 test * Testing fix for EPOS4 external * Revert "Implemented GeneratorEPOS4 test" This reverts commit e0b88b1. * Reapply "Implemented GeneratorEPOS4 test" This reverts commit 53671e8. * Revert "Testing fix for EPOS4 external" This reverts commit 920cf42. * Check for LIBDIR * Added EPO4 as env variable in external script * Explicit definition of EPOS4 version * Reorganised and improved fix for CI
include mandatory interactionRate argument
* add X3872 and Psi2S to Jpsi pi pi
…Group#1813) * Update generator_pythia8_extraStrangeness.C * Update generator_pythia8_syntheFlowXi.C
* Rho prime process * Decay in SL
Head branch was pushed to by a user without write access
maciacco
requested review from
a team,
davidrohr,
jackal1-66 and
shahor02
as code owners
17 participants
@mconcas @sawenzel I added the parallel world configurables in the python and bash scripts for the anchored workflow creation. I also added a variable in the pp test script to enable the parallel geometry navigation