[PWGEM] Clean up of clang-tidy errors and warnings from #17288 (#17310)

Author: mhemmer-cern

PWGEM/PhotonMeson/TableProducer/photonconversionbuilder.cxx

@@ -52,6 +52,7 @@
 #include <Framework/HistogramSpec.h>
 #include <Framework/InitContext.h>
 #include <Framework/runDataProcessing.h>
+#include <ReconstructionDataFormats/HelixHelper.h>
 #include <ReconstructionDataFormats/PID.h>
 
 #include <Math/Vector4D.h> // IWYU pragma: keep (do not replace with Math/Vector4Dfwd.h)
@@ -62,6 +63,8 @@
 #include <KFPVertex.h>
 #include <KFParticle.h>
 
+#include <GPUROOTCartesianFwd.h>
+
 #include <algorithm>
 #include <array>
 #include <cmath>
@@ -681,9 +684,8 @@ struct PhotonConversionBuilder {
           phiv = o2::aod::pwgem::dilepton::utils::pairutil::getPhivPair(kfp_track_posProp.GetPx(), kfp_track_posProp.GetPy(), kfp_track_posProp.GetPz(), kfp_track_eleProp.GetPx(), kfp_track_eleProp.GetPy(), kfp_track_eleProp.GetPz(), pos.sign(), ele.sign(), d_bz);
           psipair = o2::aod::pwgem::dilepton::utils::pairutil::getPsiPair(kfp_track_posProp.GetPx(), kfp_track_posProp.GetPy(), kfp_track_posProp.GetPz(), kfp_track_eleProp.GetPx(), kfp_track_eleProp.GetPy(), kfp_track_eleProp.GetPz());
           break;
-        } else {
-          LOG(debug) << "Propagation to offset" << offsetR << " cm failed for " << (pPropagatedSuccess ? "negative" : "positive") << " track. Trying smaller offset.";
         }
+        LOG(debug) << "Propagation to offset" << offsetR << " cm failed for " << (pPropagatedSuccess ? "negative" : "positive") << " track. Trying smaller offset.";
       }
       if (modeTrackPropagation == TrackPropMode::kBoth) {
         registry.fill(HIST("V0/hPhivPropagationCompare"), phiv, phivFast);

PWGEM/PhotonMeson/Utils/PCMUtilities.h

@@ -30,6 +30,8 @@
 #include <Math/Vector2D.h>                       // IWYU pragma: keep (do not replace with Math/Vector2Dfwd.h)
 #include <Math/Vector2Dfwd.h>
 
+#include <GPUROOTCartesianFwd.h>
+
 #include <array>
 #include <cmath>
 
@@ -113,7 +115,7 @@ template <typename TrackPrecision = float>
 std::array<float, 2> CalculateDCAFast(const o2::track::TrackParametrizationWithError<TrackPrecision>& trk, const o2::math_utils::Point3D<float>& vtx, const float magField)
 {
 
-  std::array<float, 2> dca;
+  std::array<float, 2> dca{};
 
   // obtain circle from track in x-y plane
   const o2::track::TrackAuxPar helixPos(trk, magField);
@@ -175,7 +177,7 @@ inline std::array<float, 3> getPropMomentumFromTrackHelix(const float s, const T
   const auto phi = RecoDecay::constrainAngle<float>(track.phi() + dphi + addPhi);
 
   // Calculate px,y,z at the new propagated vertex
-  std::array<float, 3> trackP;
+  std::array<float, 3> trackP{};
   trackP[0] = std::cos(phi) * track.pt();
   trackP[1] = std::sin(phi) * track.pt();
   trackP[2] = track.tgl() * track.pt();