Skip to content

Commit 790c598

Browse files
author
Robin
committed
Removed ID field from subhandler, forcing it to be uint32_t
1 parent cd05eb1 commit 790c598

File tree

2 files changed

+26
-26
lines changed

2 files changed

+26
-26
lines changed

src/alice/handler.hpp

+14-14
Original file line numberDiff line numberDiff line change
@@ -161,18 +161,18 @@ namespace dota {
161161
*
162162
* If Obj and Data have the same type, Data will be treated as if it was already parsed.
163163
*/
164-
template <typename Obj, typename Id, typename Data, typename IdSelf>
164+
template <typename Obj, typename Data, typename IdSelf>
165165
class handlersub {
166166
public:
167167
/** Type for parent object each message of this type inherits from */
168168
typedef Obj obj_t;
169169
/** Type of the object id to manage relations */
170-
typedef Id id_t;
170+
typedef uint32_t id_t;
171171

172172
/** Type for the parameter of the callback function */
173-
typedef cbObject<Obj, Id>* callbackObj_t;
173+
typedef cbObject<Obj, uint32_t>* callbackObj_t;
174174
/** Pointer-less type for the callback object */
175-
typedef cbObject<Obj, Id> callbackObjS_t;
175+
typedef cbObject<Obj, uint32_t> callbackObjS_t;
176176
/** Type for the callback signature */
177177
typedef delegate<void, callbackObj_t> delegate_t;
178178

@@ -243,14 +243,14 @@ namespace dota {
243243
}
244244
private:
245245
/** Type for a list of registered callbacks */
246-
typedef std::vector<std::vector<delegate_t>> cbmap_t;
246+
typedef std::vector<std::vector<delegate_t>> cblist_t;
247247
/** Callback list */
248-
cbmap_t cb;
248+
cblist_t cb;
249249

250250
/** Type for a list of registered objects */
251-
typedef std::vector<obj_t (*)(Data&&)> objmap_t;
251+
typedef std::vector<obj_t (*)(Data&&)> objlist_t;
252252
/** Object list */
253-
objmap_t obj;
253+
objlist_t obj;
254254

255255
/** Called if the message needs to be parsed from the data */
256256
void forward(const id_t& i, Data &&data, uint32_t tick, std::false_type);
@@ -447,12 +447,12 @@ namespace dota {
447447

448448
/** Type for our default handler */
449449
typedef handler<
450-
handlersub< uint32_t, uint32_t, uint32_t, msgStatus >,
451-
handlersub< ::google::protobuf::Message*, uint32_t, demMessage_t, msgDem >,
452-
handlersub< ::google::protobuf::Message*, uint32_t, demMessage_t, msgUser >,
453-
handlersub< ::google::protobuf::Message*, uint32_t, demMessage_t, msgNet >,
454-
handlersub< entity*, uint32_t, entity*, msgEntity >,
455-
handlersub< entity_delta*, uint32_t, entity_delta*, msgEntityDelta >
450+
handlersub< uint32_t, uint32_t, msgStatus >,
451+
handlersub< ::google::protobuf::Message*, demMessage_t, msgDem >,
452+
handlersub< ::google::protobuf::Message*, demMessage_t, msgUser >,
453+
handlersub< ::google::protobuf::Message*, demMessage_t, msgNet >,
454+
handlersub< entity*, entity*, msgEntity >,
455+
handlersub< entity_delta*, entity_delta*, msgEntityDelta >
456456
> handler_t;
457457

458458
/// @}

src/alice/handler_impl.hpp

+12-12
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
*
2121
*/
2222

23-
template <typename Obj, typename Id, typename Data, typename IdSelf>
24-
void handlersub<Obj, Id, Data, IdSelf>::
23+
template <typename Obj, typename Data, typename IdSelf>
24+
void handlersub<Obj, Data, IdSelf>::
2525
forward(const id_t& i, Data &&data, uint32_t tick, std::false_type) {
2626
// check for callback handlers
2727
if (cb.size() <= i)
@@ -37,16 +37,16 @@ forward(const id_t& i, Data &&data, uint32_t tick, std::false_type) {
3737
);
3838

3939
// create object
40-
cbObject<Obj, Id> o(obj[i](std::move(data)), tick, i);
40+
cbObject<Obj, uint32_t> o(obj[i](std::move(data)), tick, i);
4141

4242
// forward to definitive handlers
4343
for (auto &d : cb[i]) {
4444
d(&o);
4545
}
4646
}
4747

48-
template <typename Obj, typename Id, typename Data, typename IdSelf>
49-
void handlersub<Obj, Id, Data, IdSelf>::
48+
template <typename Obj, typename Data, typename IdSelf>
49+
void handlersub<Obj, Data, IdSelf>::
5050
forward(const id_t& i, Data &&data, uint32_t tick, std::true_type) {
5151
// check for callback handlers
5252
if (cb.size() <= i)
@@ -56,16 +56,16 @@ forward(const id_t& i, Data &&data, uint32_t tick, std::true_type) {
5656
return;
5757

5858
// create object
59-
cbObject<Obj, Id> o(std::move(data), tick, i, false);
59+
cbObject<Obj, uint32_t> o(std::move(data), tick, i, false);
6060

6161
// forward to definitive handlers
6262
for (auto &d : cb[i]) {
6363
d(&o);
6464
}
6565
}
6666

67-
template <typename Obj, typename Id, typename Data, typename IdSelf>
68-
typename handlersub<Obj, Id, Data, IdSelf>::callbackObjS_t handlersub<Obj, Id, Data, IdSelf>::
67+
template <typename Obj, typename Data, typename IdSelf>
68+
typename handlersub<Obj, Data, IdSelf>::callbackObjS_t handlersub<Obj, Data, IdSelf>::
6969
retrieve(const id_t& i, Data &&data, uint32_t tick, std::false_type) {
7070
// get conversion object
7171
if (obj.size() <= i || obj[i] == nullptr)
@@ -74,13 +74,13 @@ retrieve(const id_t& i, Data &&data, uint32_t tick, std::false_type) {
7474
);
7575

7676
// return object
77-
return cbObject<Obj, Id>(obj[i](std::move(data)), tick, i);
77+
return cbObject<Obj, uint32_t>(obj[i](std::move(data)), tick, i);
7878
}
7979

80-
template <typename Obj, typename Id, typename Data, typename IdSelf>
81-
typename handlersub<Obj, Id, Data, IdSelf>::callbackObjS_t handlersub<Obj, Id, Data, IdSelf>::
80+
template <typename Obj, typename Data, typename IdSelf>
81+
typename handlersub<Obj, Data, IdSelf>::callbackObjS_t handlersub<Obj, Data, IdSelf>::
8282
retrieve(const id_t& i, Data &&data, uint32_t tick, std::true_type) {
83-
return cbObject<Obj, Id>(std::move(data), tick, i);
83+
return cbObject<Obj, uint32_t>(std::move(data), tick, i);
8484
}
8585

8686
template <typename T1, typename... Rest>

0 commit comments

Comments
 (0)