Skip to content

Commit 2a00270

Browse files
committed
Fix async errors in example resource and commands
1 parent 631127c commit 2a00270

File tree

3 files changed

+9
-15
lines changed

3 files changed

+9
-15
lines changed

src/AlternateLife.RageMP.Net.Example/Server/CommandHandler.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class CommandHandler : ICommandHandler
1212
[Command("vehicle")]
1313
public async Task Vehicle(IPlayer player, string[] arguments)
1414
{
15-
var vehicle = await MP.Vehicles.NewAsync(VehicleHash.Elegy, player.Position);
15+
var vehicle = await MP.Vehicles.NewAsync(VehicleHash.Elegy, await player.GetPositionAsync());
1616

1717
player.PutIntoVehicle(vehicle, -1);
1818

src/AlternateLife.RageMP.Net.Example/Server/ExampleResource.cs

+7-13
Original file line numberDiff line numberDiff line change
@@ -26,27 +26,21 @@ public Task OnStopAsync()
2626
return Task.CompletedTask;
2727
}
2828

29-
private Task OnPlayerJoin(IPlayer player)
29+
private async Task OnPlayerJoin(IPlayer player)
3030
{
31-
MP.Logger.Info($"Player {player.SocialClubName} ({player.Ip}) joined!");
32-
33-
return Task.CompletedTask;
31+
MP.Logger.Info($"Player {await player.GetSocialClubNameAsync()} ({await player.GetIpAsync()}) joined!");
3432
}
3533

36-
private Task OnPlayerReady(IPlayer player)
34+
private async Task OnPlayerReady(IPlayer player)
3735
{
38-
player.Dimension = MP.GlobalDimension;
39-
40-
MP.Logger.Info($"Player {player.SocialClubName} ({player.Ip}) is ready now.");
36+
await player.SetDimensionAsync(MP.GlobalDimension);
4137

42-
return Task.CompletedTask;
38+
MP.Logger.Info($"Player {await player.GetSocialClubNameAsync()} ({await player.GetIpAsync()}) is ready now.");
4339
}
4440

45-
private Task OnPlayerDeath(IPlayer player, uint reason, IPlayer killerplayer)
41+
private async Task OnPlayerDeath(IPlayer player, uint reason, IPlayer killerplayer)
4642
{
47-
player.Spawn(player.Position, player.Heading);
48-
49-
return Task.CompletedTask;
43+
player.Spawn(await player.GetPositionAsync(), await player.GetHeadingAsync());
5044
}
5145
}
5246
}

src/AlternateLife.RageMP.Net/Scripting/ScriptingClasses/Commands.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public async Task ExecuteCommand(IPlayer player, string commandText)
150150
}
151151
catch (Exception e)
152152
{
153-
_logger.Error($"An error occured when player {player.Name} executed command: {commandName}: ", e);
153+
_logger.Error($"An error occured when player {await player.GetNameAsync()} executed command: {commandName}: ", e);
154154
}
155155
}
156156
}

0 commit comments

Comments
 (0)