feat: add MSSQL/Fabric support to data-parity skill

[suryaiyer95]

Summary

• SQL Server driver: full connect/execute/listSchemas/listTables/describeTable/close with T-SQL TOP injection, sys.* catalog queries, and row flattening for unnamed columns
• Azure AD authentication: 7 flows (default, password, access-token, service-principal-secret, msi-vm, msi-app-service) with shorthand aliases (cli, default, password, service-principal, msi)
• Dialect mapping: sqlserver/mssql → tsql, fabric → fabric with DATETRUNC() and CONVERT(DATE, ..., 23) for date partitioning
• mssql v12 upgrade: ConnectionPool isolation for concurrent connections, unnamed-column array flattening, synthetic column name fallback
• SKILL.md documentation: Fabric connection config, Azure AD auth types, algorithm behavior, schema inspection queries
• 28 driver unit tests + 9 dialect mapping tests

Key files

Area	Files
Driver	packages/drivers/src/sqlserver.ts, packages/drivers/test/sqlserver-unit.test.ts
Dialect mapping	packages/opencode/src/altimate/native/connections/data-diff.ts
Tool registration	packages/opencode/src/altimate/tools/data-diff.ts
Skill docs	.opencode/skills/data-parity/SKILL.md

Test plan

• bun test packages/drivers/test/sqlserver-unit.test.ts — 28 tests pass
• bun test packages/opencode/test/altimate/data-diff-dialect.test.ts — 9 tests pass
• Integration test against real MSSQL/Fabric instance
• Verify Azure AD auth flows with actual Azure credentials

🤖 Generated with Claude Code

---

Summary by cubic

Adds end-to-end MSSQL and Microsoft Fabric support to the data-parity skill with Azure AD auth, Rust dialect mapping (tsql/fabric), and an upgraded mssql v12 driver. For default/CLI Azure AD, the driver now acquires tokens via @azure/identity or falls back to Azure CLI to avoid Bun resolution issues; docs note minimum versions and @azure/identity as optional for Azure AD.

• New Features

  • Full MSSQL/Fabric support in data_diff (auto, joindiff, hashdiff, profile, cascade) with date partitioning via DATETRUNC() and CONVERT(DATE, ..., 23); maps sqlserver/mssql→tsql, fabric→fabric; improved query detection (keyword + whitespace).
  • SQL Server driver: 7 Azure AD flows with shorthands (default/CLI, password, service-principal, msi), TLS enforced for AAD; for default/CLI, get an access token using @azure/identity or az CLI fallback; explicit ConnectionPool isolation; T‑SQL TOP injection with ExecuteOptions.noLimit; robust result shaping for unnamed columns and synthetic column names when needed.
  • Registry/config/docs: register fabric to reuse the SQL Server driver; add normalize aliases for authentication and Azure fields; mssql upgraded to v12; SKILL docs include minimum versions and a Fabric connection guide; @azure/identity listed as an optional peer dependency (only needed for Azure AD).

• Bug Fixes

  • Limits and detection: noLimit bypasses injected TOP; stable SQL-vs-table detection.
  • Results and partitions: only flatten the empty‑key array for unnamed columns; preserve underscore‑prefixed columns; escape single quotes and cast partition dates with CONVERT(DATE, ..., 23); show "(no values)" when diff rows have no values; added fabric to password-driver validation.

^{Written for commit e40a24b. Summary will update on new commits.}

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4812f0d4-fe06-4e3a-8245-dd19d687b959

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/mssql-fabric-data-parity

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

5 issues found across 30 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/opencode/src/altimate/native/connections/data-diff.ts">

<violation number="1" location="packages/opencode/src/altimate/native/connections/data-diff.ts:266">
P2: Missing single-quote escaping on `partitionValue` in the date-mode branches. The categorical mode (6 lines above) escapes with `.replace(/'/g, "''")`, but none of the date-mode `switch` cases do. Apply the same escaping for consistency and defense in depth.</violation>

<violation number="2" location="packages/opencode/src/altimate/native/connections/data-diff.ts:489">
P2: `partitionColumn` is not identifier-quoted in `buildPartitionDiscoverySQL`, but it is quoted in `buildPartitionWhereClause`. If the column name is a reserved word (e.g. `date`, `order`), the discovery query will produce a syntax error. Quote the column consistently between both functions.</violation>
</file>

<file name="packages/opencode/src/altimate/native/connections/registry.ts">

<violation number="1" location="packages/opencode/src/altimate/native/connections/registry.ts:125">
P2: `fabric` is missing from the `PASSWORD_DRIVERS` set. Since it maps to the same sqlserver driver as `sqlserver`/`mssql` (both present in the set), `fabric` should also be included to get the same friendly error when `password` is not a string.</violation>
</file>

<file name="packages/opencode/src/altimate/tools/data-diff.ts">

<violation number="1" location="packages/opencode/src/altimate/tools/data-diff.ts:206">
P2: When `d.values` is nullish, `d.values?.join(" | ")` evaluates to `undefined`, which the template literal coerces to the string `"undefined"`. The output would read e.g. `[source only] undefined`. Use a fallback to produce a sensible message.</violation>
</file>

<file name="packages/drivers/src/sqlserver.ts">

<violation number="1" location="packages/drivers/src/sqlserver.ts:148">
P1: `flattenRow` flattens all array values, but only the empty-string key (`""`) holds mssql's merged unnamed columns. A legitimate array column value (e.g. from JSON aggregation) will be incorrectly spread, corrupting the row data and misaligning columns. Restrict flattening to the `""` key only.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[anandgupta42]

@suryaiyer95 can you address code review comments?

[cubic-dev-ai]

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/drivers/src/sqlserver.ts">

<violation number="1" location="packages/drivers/src/sqlserver.ts:90">
P2: Avoid `execSync` in the async connection path; it can block the event loop for up to the CLI timeout.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

P2: Avoid execSync in the async connection path; it can block the event loop for up to the CLI timeout.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/drivers/src/sqlserver.ts, line 90:

<comment>Avoid `execSync` in the async connection path; it can block the event loop for up to the CLI timeout.</comment>

<file context>
@@ -54,24 +54,60 @@ export async function connect(config: ConnectionConfig): Promise<Connector> {
+          // Attempt 2: Azure CLI subprocess (universal fallback)
+          if (!token) {
+            try {
+              const { execSync } = await import("node:child_process")
+              const json = execSync(
+                "az account get-access-token --resource https://database.windows.net/ --query accessToken -o tsv",
</file context>

Suggested change

	const { execSync } = await import("node:child_process")
	const json = execSync(
	"az account get-access-token --resource https://database.windows.net/ --query accessToken -o tsv",
	{ encoding: "utf-8", timeout: 15000, stdio: ["pipe", "pipe", "pipe"] },
	).trim()
	if (json) token = json
	const { execFile } = await import("node:child_process")
	const cliToken = await new Promise<string>((resolve, reject) => {
	execFile(
	"az",
	["account", "get-access-token", "--resource", "https://database.windows.net/", "--query", "accessToken", "-o", "tsv"],
	{ timeout: 15000 },
	(error, stdout) => {
	if (error) return reject(error)
	resolve((stdout ?? "").toString().trim())
	},
	)
	})
	if (cliToken) token = cliToken