Merge pull request #706 from Altinity/antalya-25.2

Antalya 25.2

Author: Enmk

.clang-format

@@ -83,6 +83,7 @@ NamespaceIndentation: None
 ObjCBlockIndentWidth: 4
 ObjCSpaceAfterProperty: true
 ObjCSpaceBeforeProtocolList: true
+PackConstructorInitializers: Never
 PenaltyBreakBeforeFirstCallParameter: 19
 PenaltyBreakComment: 300
 PenaltyBreakFirstLessLess: 120

.clang-tidy

@@ -17,34 +17,23 @@ Checks: [
   '-android-*',
 
   '-boost-use-ranges',
-  '-modernize-use-ranges',
 
   '-bugprone-assignment-in-if-condition',
   '-bugprone-branch-clone',
   '-bugprone-easily-swappable-parameters',
   '-bugprone-exception-escape',
-  '-bugprone-forward-declaration-namespace',
   '-bugprone-implicit-widening-of-multiplication-result',
   '-bugprone-multi-level-implicit-pointer-conversion',
   '-bugprone-narrowing-conversions',
-  '-bugprone-not-null-terminated-result',
   '-bugprone-unchecked-optional-access',
   '-bugprone-crtp-constructor-accessibility',
+  '-bugprone-not-null-terminated-result',
 
   '-cert-dcl16-c',
   '-cert-err58-cpp',
-  '-cert-msc32-c',
-  '-cert-msc51-cpp',
-  '-cert-oop54-cpp',
-  '-cert-oop57-cpp',
-  '-cert-err33-c', # Misreports on clang-19: it warns about all functions containing 'remove' in the name, not only about the standard library.
 
   '-clang-analyzer-optin.performance.Padding',
 
-  '-clang-analyzer-cplusplus.PlacementNew',
-
-  '-clang-analyzer-unix.Malloc',
-
   '-cppcoreguidelines-*', # impractical in a codebase as large as ClickHouse, also slow
 
   '-darwin-*',
@@ -77,39 +66,34 @@ Checks: [
   '-hicpp-use-emplace',
   '-hicpp-vararg',
 
-  '-linuxkernel-*',
-
   '-llvm-*',
 
   '-llvmlibc-*',
 
-  '-openmp-*',
-
   '-misc-const-correctness',
   '-misc-include-cleaner', # useful but far too many occurrences
   '-misc-no-recursion',
   '-misc-non-private-member-variables-in-classes',
-  '-misc-confusable-identifiers', # useful but slooo
   '-misc-use-anonymous-namespace',
   '-misc-use-internal-linkage',
 
   '-modernize-avoid-c-arrays',
   '-modernize-concat-nested-namespaces',
-  '-modernize-macro-to-enum',
   '-modernize-pass-by-value',
   '-modernize-return-braced-init-list',
   '-modernize-use-auto',
-  '-modernize-use-constraints', # This is a good check, but clang-tidy crashes, see https://github.com/llvm/llvm-project/issues/91872
   '-modernize-use-default-member-init',
   '-modernize-use-emplace',
   '-modernize-use-nodiscard',
+  '-modernize-use-ranges',
   '-modernize-use-trailing-return-type',
   '-modernize-use-designated-initializers',
 
+  '-performance-avoid-endl',
   '-performance-enum-size',
   '-performance-inefficient-string-concatenation',
+  '-performance-inefficient-vector-operation',
   '-performance-no-int-to-ptr',
-  '-performance-avoid-endl',
   '-performance-unnecessary-value-param',
 
   '-portability-simd-intrinsics',
@@ -124,7 +108,6 @@ Checks: [
   '-readability-identifier-length',
   '-readability-identifier-naming', # useful but too slow
   '-readability-implicit-bool-conversion',
-  '-readability-isolate-declaration',
   '-readability-magic-numbers',
   '-readability-named-parameter',
   '-readability-redundant-declaration',

.clangd

@@ -14,3 +14,6 @@ Diagnostics:
             readability-identifier-naming,
             bugprone-reserved-identifier,
         ]
+# Require LLVM 20 (https://github.com/llvm/llvm-project/pull/67749)
+Style:
+  AngledHeaders: [".*"]

.github/ISSUE_TEMPLATE/20_feature-request.md

@@ -0,0 +1,38 @@
+name: Feature request
+description: Suggest an idea for ClickHouse
+labels: ["feature"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        > (you don't have to strictly follow this form)
+  - type: textarea
+    attributes:
+      label: Company or project name
+      description: Put your company name or project description here.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Use case
+      description: A clear and concise description of what the intended usage scenario is.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Describe the solution you'd like
+      description: A clear and concise description of what you want to happen.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Describe alternatives you've considered
+      description: A clear and concise description of any alternative solutions or features you've considered.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Additional context
+      description: Add any other context or screenshots about the feature request here.
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/20_feature-request.yaml

@@ -0,0 +1,50 @@
+name: Unexpected behaviour
+description: Some feature is working in non-obvious way
+labels: ["unexpected behaviour"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        > (you don't have to strictly follow this form)
+  - type: textarea
+    attributes:
+      label: Company or project name
+      description: Put your company name or project description here.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Describe the unexpected behaviour
+      description: A clear and concise description of what works not as it is supposed to.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: How to reproduce
+      description: |
+        * Which ClickHouse server version to use
+        * Which interface to use, if matters
+        * Non-default settings, if any
+        * `CREATE TABLE` statements for all tables involved
+        * Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
+        * Queries to run that lead to unexpected result
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Expected behavior
+      description: A clear and concise description of what you expected to happen.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Error message and/or stacktrace
+      description: If applicable, add screenshots to help explain your problem.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Additional context
+      description: Add any other context about the problem here.
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/30_unexpected-behaviour.yaml

@@ -0,0 +1,50 @@
+name: Incomplete implementation
+description: Implementation of existing feature is not finished
+labels: ["unfinished code"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        > (you don't have to strictly follow this form)
+  - type: textarea
+    attributes:
+      label: Company or project name
+      description: Put your company name or project description here.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Describe the unexpected behaviour
+      description: A clear and concise description of what works not as it is supposed to.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: How to reproduce
+      description: |
+        * Which ClickHouse server version to use
+        * Which interface to use, if matters
+        * Non-default settings, if any
+        * `CREATE TABLE` statements for all tables involved
+        * Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
+        * Queries to run that lead to unexpected result
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Expected behavior
+      description: A clear and concise description of what you expected to happen.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Error message and/or stacktrace
+      description: If applicable, add screenshots to help explain your problem.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Additional context
+      description: Add any other context about the problem here.
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/35_incomplete_implementation.yaml

@@ -0,0 +1,50 @@
+name: Usability issue
+description: Report something can be made more convenient to use
+labels: ["usability"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        > (you don't have to strictly follow this form)
+  - type: textarea
+    attributes:
+      label: Company or project name
+      description: Put your company name or project description here.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Describe the unexpected behaviour
+      description: A clear and concise description of what works not as it is supposed to.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: How to reproduce
+      description: |
+        * Which ClickHouse server version to use
+        * Which interface to use, if matters
+        * Non-default settings, if any
+        * `CREATE TABLE` statements for all tables involved
+        * Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
+        * Queries to run that lead to unexpected result
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Expected behavior
+      description: A clear and concise description of what you expected to happen.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Error message and/or stacktrace
+      description: If applicable, add screenshots to help explain your problem.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Additional context
+      description: Add any other context about the problem here.
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/45_usability-issue.yaml

@@ -0,0 +1,44 @@
+name: Build issue
+description: Report failed ClickHouse build from master
+labels: ["build"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        > Make sure that `git diff` result is empty and you've just pulled fresh master. Try cleaning up cmake cache. Just in case, official build instructions are published here: https://clickhouse.com/docs/en/development/build/
+  - type: textarea
+    attributes:
+      label: Company or project name
+      description: Put your company name or project description here.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Operating system
+      description: OS kind or distribution, specific version/release, non-standard kernel if any. If you are trying to build inside virtual machine, please mention it too.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: CMake version
+      description: The output of `cmake --version`.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Ninja version
+      description: The output of `ninja --version`.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Compiler name and version
+      description: We recommend to use clang. The version can be obtained via `clang --version`.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Full cmake and/or ninja output
+      description: Please include everything!
+    validations:
+      required: true

.github/ISSUE_TEMPLATE/50_build-issue.yaml

@@ -0,0 +1,26 @@
+name: Documentation issue
+description: Report something incorrect or missing in documentation
+labels: ["comp-documentation"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        > Make sure that `git diff` result is empty and you've just pulled fresh master. Try cleaning up cmake cache. Just in case, official build instructions are published here: https://clickhouse.com/docs/en/development/build/
+  - type: textarea
+    attributes:
+      label: Company or project name
+      description: Put your company name or project description here.
+    validations:
+      required: false
+  - type: textarea
+    attributes:
+      label: Describe the issue
+      description: A clear and concise description of what's wrong in documentation.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Additional context
+      description: Add any other context about the problem here.
+    validations:
+      required: false