call unalignedLoad

arthurpassos · arthurpassos · commit 1244161b9a3d · 2025-03-13T12:56:07.000-03:00
diff --git a/src/Processors/Formats/Impl/Parquet/ParquetDataBuffer.h b/src/Processors/Formats/Impl/Parquet/ParquetDataBuffer.h
@@ -56,12 +56,8 @@ class ParquetDataBuffer
 
         for (std::size_t i = 0; i < count; i++)
         {
-            ParquetType temp;
             auto offset = i * sizeof(ParquetType);
-
-            // necessary to prevent memory alignment issues https://github.com/ClickHouse/ClickHouse/issues/74512#issuecomment-2587260001
-            memcpy(&temp, data + offset, sizeof(ParquetType));
-            dst[i] = static_cast<TValue>(temp);
+            dst[i] = unalignedLoad<TValue>(data + offset);
         }
 
         consume(necessary_bytes);

Original file line number	Diff line number	Diff line change
`@@ -56,12 +56,8 @@ class ParquetDataBuffer`
`56`	`56`
`57`	`57`	`for (std::size_t i = 0; i < count; i++)`
`58`	`58`	`{`
`59`		`- ParquetType temp;`
`60`	`59`	`auto offset = i * sizeof(ParquetType);`
`61`		`-`
`62`		`- // necessary to prevent memory alignment issues https://github.com/ClickHouse/ClickHouse/issues/74512#issuecomment-2587260001`
`63`		`- memcpy(&temp, data + offset, sizeof(ParquetType));`
`64`		`- dst[i] = static_cast<TValue>(temp);`
	`60`	`+ dst[i] = unalignedLoad<TValue>(data + offset);`
`65`	`61`	`}`
`66`	`62`
`67`	`63`	`consume(necessary_bytes);`