Skip to content

Commit 926c396

Browse files
committed
fix regression aws secrets and robot token function
1 parent 781e811 commit 926c396

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

.github/workflows/regression.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ name: Regression test workflow - Release
8888
env:
8989
# Force the stdout and stderr streams to be unbuffered
9090
PYTHONUNBUFFERED: 1
91-
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_REPORT_KEY_ID }}
92-
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_REPORT_SECRET_ACCESS_KEY }}
93-
AWS_DEFAULT_REGION: ${{ secrets.AWS_REPORT_REGION }}
91+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
92+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
93+
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}
9494
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
9595
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
9696
CHECKS_DATABASE_HOST: ${{ secrets.CHECKS_DATABASE_HOST }}

tests/ci/get_robot_token.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,11 @@ def get_parameters_from_ssm(
5757

5858
return results
5959

60-
61-
ROBOT_TOKEN = None # type: Optional[Token]
62-
6360
# NOTE(Arthur Passos): Original CI code uses the "_original" version of this method. Each robot token is rate limited
6461
# and the original implementation selects the "best one". To make it simpler and iterate faster,
6562
# we are using only one robot and keeping the method signature. In the future we might reconsider
6663
# having multiple robot tokens
67-
def get_best_robot_token(token_prefix_env_name="github_robot_token"):
68-
# Re-use already fetched token (same as in get_best_robot_token_original)
69-
# except here we assume it is always a string (since we use only one token and don't do token rotation)
64+
def get_best_robot_token():
7065
return ROBOT_TOKEN
7166

7267
def get_best_robot_token_original(tokens_path: str = "/github-tokens") -> str:

0 commit comments

Comments
 (0)