Skip to content

Commit abea224

Browse files
committed
fix parquet tests properly
1 parent 15ef08e commit abea224

File tree

4 files changed

+12
-17
lines changed

4 files changed

+12
-17
lines changed

parquet/configs/clickhouse/users.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,11 @@
8787
<!-- Allow access management -->
8888
<access_management>1</access_management>
8989

90+
<!-- Allow access to named collections -->
91+
<named_collection_control>1</named_collection_control>
92+
<show_named_collections>1</show_named_collections>
93+
<show_named_collections_secrets>1</show_named_collections_secrets>
94+
9095
<!-- Example of row level security policy. -->
9196
<!-- <databases>
9297
<test>

parquet/configs/users.d/users.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,6 @@
8888
<!-- Allow access management -->
8989
<access_management>1</access_management>
9090

91-
<!-- Allow access to named collections -->
92-
<named_collection_control>1</named_collection_control>
93-
<show_named_collections>1</show_named_collections>
94-
<show_named_collections_secrets>1</show_named_collections_secrets>
95-
9691
<!-- Example of row level security policy. -->
9792
<!-- <databases>
9893
<test>

parquet/configs/users.d/users_disabled_caching.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,6 @@
8787
<!-- Allow access management -->
8888
<access_management>1</access_management>
8989

90-
<!-- Allow access to named collections -->
91-
<named_collection_control>1</named_collection_control>
92-
<show_named_collections>1</show_named_collections>
93-
<show_named_collections_secrets>1</show_named_collections_secrets>
94-
9590
<!-- Example of row level security policy. -->
9691
<!-- <databases>
9792
<test>

parquet/tests/s3.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -442,13 +442,6 @@ def outline(self, compression_type):
442442
self.context.compression_type = compression_type
443443
self.context.node = self.context.cluster.node("clickhouse1")
444444

445-
with Given("I add S3 credentials configuration"):
446-
named_s3_credentials(
447-
access_key_id=self.context.access_key_id,
448-
secret_access_key=self.context.secret_access_key,
449-
restart=True,
450-
)
451-
452445
Suite(run=engine)
453446
Suite(run=function)
454447

@@ -483,6 +476,13 @@ def feature(self):
483476
"""Run checks for ClickHouse using Parquet format using `S3` table engine and `s3` table function
484477
using different compression types."""
485478

479+
with Given("I add S3 credentials configuration"):
480+
named_s3_credentials(
481+
access_key_id=self.context.access_key_id,
482+
secret_access_key=self.context.secret_access_key,
483+
restart=True,
484+
)
485+
486486
with Feature("compression type"):
487487
with Pool(3) as executor:
488488
Feature(

0 commit comments

Comments
 (0)