feat: changed behaviour from @ref (AnWeber/vscode-httpyac#336)

Author: AnWeber

CHANGELOG.md

@@ -1,3 +1,18 @@
+## [6.16.3] (2024-10-30)
+
+### Fix
+- revert: named response is only set, if all testResults are valid
+- changed behaviour from `@ref` (AnWeber/vscode-httpyac#336)
+  - negative test results from reference does not stop dependent request
+  - errored reference is not executed multiple times if it is referenced multiple times
+
+
+## [6.16.2] (2024-10-29)
+
+### Fix
+- named response is only set, if all testResults are valid
+
+
 ## [6.16.1] ( 2024-10-29)
 
 ### Fix

package-lock.json

@@ -4,7 +4,7 @@
   "license": "MIT",
   "publisher": "AnWeber",
   "description": "HTTP/REST CLI Client for *.http files",
-  "version": "6.16.1",
+  "version": "6.16.3",
   "homepage": "https://github.com/AnWeber/httpyac",
   "repository": {
     "type": "git",

package.json

@@ -39,16 +39,14 @@ class RefMetaAction {
       const envKey = utils.toEnvironmentKey(context.activeEnvironment);
       utils.setVariableInContext(reference.variablesPerEnv[envKey], context);
       log.trace('import variables', reference.variablesPerEnv[envKey]);
-      if (this.data.force || utils.isUndefined(context.variables[name])) {
+
+      const isNotExecuted =
+        utils.isUndefined(context.variables[name]) && !context.processedHttpRegions?.some(p => p.id === reference.id);
+      if (this.data.force || isNotExecuted) {
         result = await reference.execute(context);
         if (result) {
           // ref to ref variable export
           utils.setVariableInContext(reference.variablesPerEnv[envKey], context);
-        } else if (
-          reference.testResults &&
-          reference.testResults.some(t => t.status !== models.TestResultStatus.SUCCESS)
-        ) {
-          utils.addSkippedTestResult(context.httpRegion);
         }
       }
     } else {

src/plugins/core/metaData/refMetaDataHandler.ts

@@ -89,10 +89,7 @@ export class HttpRegion implements models.HttpRegion {
       if (!this.isGlobal()) {
         this.resetDependentRegionsWithVisitor(toEnvironmentKey(context.activeEnvironment), this, []);
       }
-      const isNotCanceled = result !== HookCancel && result.every(obj => !!obj);
-      const hasOnlySucessTestResults =
-        !this.testResults.length || this.testResults.every(t => t.status === models.TestResultStatus.SUCCESS);
-      return isNotCanceled && hasOnlySucessTestResults;
+      return result !== HookCancel && result.every(obj => !!obj);
     } catch (err) {
       if (isError(err)) {
         if (!err.handled) {