Merge pull request #78 from Angular-RU/feature/add-numeric-ignore

add numeric ignore

Author: splincode

index.js

@@ -44,7 +44,14 @@ module.exports = {
         'no-return-assign': ['error', 'always'],
         'max-params': ['error', 3],
         'no-nested-ternary': 'error',
-        'no-magic-numbers': ['error', { ignore: [-1, 0, 1] }],
+        "no-magic-numbers": "off",
+        "@typescript-eslint/no-magic-numbers": [
+            "error",
+            {
+                ignoreEnums: true,
+                ignoreNumericLiteralTypes: true,
+                ignoreReadonlyClassProperties: true
+            }],
         'sort-imports': 'off',
         'prettier/prettier': 'error',
         'import/first': 'error',

test/test.spec.ts

@@ -13,6 +13,7 @@ describe('[TEST]: Eslint', (): void => {
         expect(bad.includes("expected member-variable-declaration: 'hello' to have a typedef")).toEqual(true);
         expect(bad.includes('Missing accessibility modifier on class property hello')).toEqual(true);
         expect(bad.includes('Unexpected console statement')).toEqual(true);
+        expect(bad.includes('No magic number: 2')).toEqual(true);
     });
 
     it('check success files', (): void => {

test/typescript.bad.ts

@@ -1,10 +1,13 @@
 export class A {
+    // expect errors
+    public hi: number = 2;
     // expect errors
     hello = 1;
 }
 
 // expect errors
 console.log(new A().hello);
+console.log(new A().hi);
 
 // expect no errors
 const helloWorld: Function = function (): string {

test/typescript.good.ts

@@ -1,5 +1,19 @@
+type SmallPrimes = 2 | 3 | 5 | 7 | 11;
+
 export class A {
-    public hello: number = 1;
+    public readonly hi: SmallPrimes = 2;
+    public readonly hello: number = 1;
 }
 
+console.error(new A().hi);
 console.error(new A().hello);
+
+enum foo {
+    SECOND = 1000,
+    VALUE_1 = 3,
+    VALUE_2 = 4
+}
+
+console.error(foo.SECOND);
+console.error(foo.VALUE_1);
+console.error(foo.VALUE_2);