Skip to content

Commit 22e514d

Browse files
committed
Fix compile errors reporting in rspec
1 parent 413fc62 commit 22e514d

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

Diff for: CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
2323
- A missing `examples` directory no longer causes a crash in `cpp_library.rb`
2424
- Referring to an undefined platform no longer causes a crash; it's now a helpful error message
2525
- A copy/paste error that prevented compiler warning flags from being supplied has been fixed, via jgfoster
26+
- RSpec was not communicating compile errors from unit test executables that failed to build. Now it does, via jgfoster
2627

2728
### Security
2829

Diff for: spec/testsomething_unittests_spec.rb

+2-5
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
context "file #{tfn} (using #{compiler})" do
7373
around(:example) { |example| fld.in_pristine_fake_libraries_dir(example) }
7474

75-
before(:all) do
75+
before(:each) do
7676
@cpp_library = backend.install_local_library(cpp_lib_path)
7777
@exe = @cpp_library.build_for_test_with_configuration(path, [], compiler, config.gcc_config("uno"))
7878
end
@@ -88,11 +88,8 @@
8888
end
8989
end
9090

91-
it "#{tfn} builds successfully" do
91+
it "#{tfn} builds successfully and passes tests" do
9292
expect(@exe).not_to be nil
93-
end
94-
it "#{tfn} passes tests" do
95-
skip "Can't run the test program because it failed to build" if @exe.nil?
9693
expect(@cpp_library.run_test_file(@exe)).to_not be_falsey
9794
end
9895
end

0 commit comments

Comments
 (0)