Skip to content

Add GitHub Actions to enable testing on forks of arduino_ci #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgfoster opened this issue Nov 9, 2020 · 5 comments
Closed

Add GitHub Actions to enable testing on forks of arduino_ci #199

jgfoster opened this issue Nov 9, 2020 · 5 comments
Labels
ci scripts The test runner scripts

Comments

@jgfoster
Copy link
Member

jgfoster commented Nov 9, 2020

Set up GitHub Actions for this repository such that forks will have their own functioning CI automatically

Original text:

arduino_ci has two automated testing systems set up. We should add GitHub Actions. (I can work on this but just wanted to note it as an issue.)

@ianfixes
Copy link
Collaborator

I'm open to this, but I'm not clear on the problem being solved here. We currently test 3 platforms on every PR or code push: windows, linux, and OSX. What do GitHub actions add to this?

@jgfoster
Copy link
Member Author

This isn't adding a new operating system, this is adding a new testing infrastructure. There are two values:

First, since arduino_ci is a testing framework, it should broadly demonstrate and use the various testing platforms out there. (Actually, I didn't realize that the existing two-part actions were testing three operating systems; I thought that they were demonstrating the two primary testing hosts.)

Second, the two existing testing actions require external setup. While you have gone to the trouble to set up the external systems for this GitHub repository, the rest of us (so far) haven't bothered to do so. The virtue of GitHub Actions is that they are built in to GitHub. By forking your repository I will get the GitHub Action configuration (if/when this PR is accepted). Then my fork will automatically run tests on every push to my repository. With that, even if I fail to run the test suite before doing a local commit (hand slap!), one will be run when I do a push. This is pushing best practices to the edge.

@ianfixes
Copy link
Collaborator

Understood, I think I made the more relevant comment on #200

@ianfixes ianfixes changed the title Add GitHub Actions Add demonstration of using GitHub Actions to execute Arduino CI Nov 10, 2020
@ianfixes
Copy link
Collaborator

Thought better of it, created #203

@ianfixes ianfixes changed the title Add demonstration of using GitHub Actions to execute Arduino CI Add GitHub Actions to enable testing on forks of arduino_ci Nov 10, 2020
@ianfixes
Copy link
Collaborator

ianfixes commented Dec 9, 2020

I think this is complete, but we can reopen if I'm misreading it

@ianfixes ianfixes closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci scripts The test runner scripts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants