-
Notifications
You must be signed in to change notification settings - Fork 34
Add GitHub Actions to enable testing on forks of arduino_ci #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm open to this, but I'm not clear on the problem being solved here. We currently test 3 platforms on every PR or code push: windows, linux, and OSX. What do GitHub actions add to this? |
This isn't adding a new operating system, this is adding a new testing infrastructure. There are two values: First, since Second, the two existing testing actions require external setup. While you have gone to the trouble to set up the external systems for this GitHub repository, the rest of us (so far) haven't bothered to do so. The virtue of GitHub Actions is that they are built in to GitHub. By forking your repository I will get the GitHub Action configuration (if/when this PR is accepted). Then my fork will automatically run tests on every push to my repository. With that, even if I fail to run the test suite before doing a local commit (hand slap!), one will be run when I do a push. This is pushing best practices to the edge. |
Understood, I think I made the more relevant comment on #200 |
Thought better of it, created #203 |
I think this is complete, but we can reopen if I'm misreading it |
Set up GitHub Actions for this repository such that forks will have their own functioning CI automatically
Original text:
The text was updated successfully, but these errors were encountered: