From 4648fda122b2c8ae96468d32ea1be7f7d48f0dbc Mon Sep 17 00:00:00 2001 From: James Foster Date: Tue, 16 Feb 2021 12:06:20 -0800 Subject: [PATCH 1/2] Use `before(:each)` rather than `before(:all)` as recommended [here](https://makandracards.com/makandra/11507-using-before-all-in-rspec-will-cause-you-lots-of-trouble-unless-you-know-what-you-are-doing) to fix #288. --- spec/testsomething_unittests_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/testsomething_unittests_spec.rb b/spec/testsomething_unittests_spec.rb index c882399f..bf3f9f62 100644 --- a/spec/testsomething_unittests_spec.rb +++ b/spec/testsomething_unittests_spec.rb @@ -72,7 +72,7 @@ context "file #{tfn} (using #{compiler})" do around(:example) { |example| fld.in_pristine_fake_libraries_dir(example) } - before(:all) do + before(:each) do @cpp_library = backend.install_local_library(cpp_lib_path) @exe = @cpp_library.build_for_test_with_configuration(path, [], compiler, config.gcc_config("uno")) end From a012fd49ad21c0fb4bc2c734c33a57ae416a62fd Mon Sep 17 00:00:00 2001 From: James Foster Date: Sun, 3 Oct 2021 14:46:47 -0700 Subject: [PATCH 2/2] Update CHANGELOG.md. --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0cac76ad..24dcf86e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Added ### Changed +- Properly report compile errors in GitHub Actions (#296) ### Deprecated