Merge pull request JuliaDatabases#120 from invenia/ed/null-sqlstate

Support NULL SQLSTATE with custom UnknownError type

Author: iamed2

deps/error_codes.jl

@@ -74,6 +74,16 @@ function generate_error_codes(io, html=error_code_html())
         println(error_enum_io, "    $error_code,")
         println(error_names_io, "    $id_name => \"$id_name\",")
     end
+
+    # unknown error
+    class = "CUN"
+    error_code = "EUNOWN"
+    println(class_enum_io, "    $class,")
+    println(alias_io, "\n\nconst UnknownErrorClass = PQResultError{$class}\n")
+    println(alias_io, "const UnknownError = PQResultError{$class, $error_code}")
+    println(error_enum_io, "    $error_code,")
+    println(error_names_io, "    UnknownError => \"UnknownError\",")
+
     println(class_enum_io, ")")
     println(error_enum_io, ")")
     println(error_names_io, ")")

src/error_codes.jl

@@ -44,6 +44,7 @@
     CHV,
     CP0,
     CXX,
+    CUN,
 )
 
 @cenum(ErrorCode,
@@ -288,6 +289,7 @@
     EXX000,
     EXX001,
     EXX002,
+    EUNOWN,
 )
 
 
@@ -703,6 +705,11 @@ const InternalError = PQResultError{CXX, EXX000}
 const DataCorrupted = PQResultError{CXX, EXX001}
 const IndexCorrupted = PQResultError{CXX, EXX002}
 
+
+const UnknownErrorClass = PQResultError{CUN}
+
+const UnknownError = PQResultError{CUN, EUNOWN}
+
 const ERROR_NAMES = Dict(
     SuccessfulCompletion => "SuccessfulCompletion",
     WarningWarning => "WarningWarning",
@@ -945,4 +952,5 @@ const ERROR_NAMES = Dict(
     InternalError => "InternalError",
     DataCorrupted => "DataCorrupted",
     IndexCorrupted => "IndexCorrupted",
+    UnknownError => "UnknownError",
 )

src/exceptions.jl

@@ -88,7 +88,7 @@ end
 function PQResultError(result::Result; verbose=false)
     msg = error_message(result; verbose=false)
     verbose_msg = verbose ? error_message(result; verbose=true) : nothing
-    code_str = error_field(result, libpq_c.PG_DIAG_SQLSTATE)
+    code_str = something(error_field(result, libpq_c.PG_DIAG_SQLSTATE), "UNOWN")
     class = parse(Class, code_str[1:2])
     code = parse(ErrorCode, code_str)
 

test/runtests.jl

@@ -885,6 +885,14 @@ end
             @test length(verbose_err.verbose_msg) > length(err.msg)
 
             close(result)
+
+            result = execute(conn, "SELECT 1;")
+            unknown_error = LibPQ.Errors.PQResultError(result; verbose=true)
+            @test unknown_error isa LibPQ.Errors.UnknownErrorClass
+            @test unknown_error isa LibPQ.Errors.UnknownError
+            @test occursin("PGresult is not an error result", unknown_error.verbose_msg)
+            close(result)
+
             close(conn)
         end