Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An example requires CSV.jl installed #17

Closed
singularitti opened this issue Apr 29, 2020 · 1 comment · Fixed by #18
Closed

An example requires CSV.jl installed #17

singularitti opened this issue Apr 29, 2020 · 1 comment · Fixed by #18
Labels
documentation Improvements or additions to documentation

Comments

@singularitti
Copy link

The first example in README.md requires CSV to be installed:

using UrlDownload
using DataFrames

url = "https://raw.githubusercontent.com/Arkoniak/UrlDownload.jl/master/data/ext.csv"

julia> df = urldownload(url) |> DataFrame
ERROR: ArgumentError: Package CSV not found in current path:
- Run `import Pkg; Pkg.add("CSV")` to install the CSV package.

Is it expected? If so, maybe a using CSV should also be added to the doc.

@Arkoniak Arkoniak added the documentation Improvements or additions to documentation label May 1, 2020
@Arkoniak
Copy link
Owner

Arkoniak commented May 1, 2020

Yes, this is expected. For this package to work, you should install necessary packages (this Error which you received tells you explicitly which one you need), but there is no need to add using CSV, since package import packages on it's own.

Thank you for raising this issue, I should add this explanation to README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants