Refactored for clarity + disable undesired mutations in mutation testing.

Disabled mutations won't be effective until Stryker 1.0.0 is released.

Author: AshleighAdams

codecov.yml .github/codecov.yml

@@ -43,7 +43,7 @@ definitions:
   mutation-test: &mutation-test
     name: Mutation Test
     run: |
-      dotnet tool install --global dotnet-stryker --version 0.22.0
+      dotnet tool install --global dotnet-stryker
       cd tests/UnitTests
       if [[ "$GITHUB_REF" == "refs/heads/master" ]]; then
         dotnet stryker \

.github/shared.yml

@@ -77,7 +77,7 @@ jobs:
 
     - name: Mutation Test
       run: |
-        dotnet tool install --global dotnet-stryker --version 0.22.0
+        dotnet tool install --global dotnet-stryker
         cd tests/UnitTests
         if [[ "$GITHUB_REF" == "refs/heads/master" ]]; then
           dotnet stryker \

.github/workflows/continuous-delivery.yml

@@ -77,7 +77,7 @@ jobs:
 
     - name: Mutation Test
       run: |
-        dotnet tool install --global dotnet-stryker --version 0.22.0
+        dotnet tool install --global dotnet-stryker
         cd tests/UnitTests
         if [[ "$GITHUB_REF" == "refs/heads/master" ]]; then
           dotnet stryker \

.github/workflows/continuous-integration.yml

@@ -58,6 +58,7 @@ private static IEnumerable<TaggedVersion> SelectWhereSemver(
 			if (head is null)
 				return (1, null);
 
+			// Stryker disable once all: used for logging only
 			return await FromCommit(
 				commit: head.Value,
 				commitDescriptor: "HEAD",
@@ -103,7 +104,9 @@ public FromCommitOptions(
 			{
 				var (current, height, rootDescriptor, heightSinceBranch) = toVisit.Pop();
 
+				// Stryker disable all: used for logging only
 				var descriptor = heightSinceBranch == 0 ? rootDescriptor : $"{rootDescriptor}~{heightSinceBranch}";
+				// Stryker restore all
 
 				// already visited in an ultimately prior parent
 				if (!visited.Add(current))
@@ -156,17 +159,23 @@ public FromCommitOptions(
 				}
 				else
 				{
-					for (int i = parents.Count; i-- > 0;)
+					// commits to visit must be added in the reverse order, so the earlier parents are visited first
+					for (int i = parents.Count; i --> 0;)
 					{
-						if (i == 0)
-							toVisit.Push((parents[i], height + 1, rootDescriptor, heightSinceBranch + 1));
-						else
-							toVisit.Push((parents[i], height + 1, $"{rootDescriptor}^{i + 1}", 0));
+						var parent = parents[i];
+						var parentHeight = height + 1;
+						// Stryker disable all: used for logging only
+						var isDiverging = i == 0;
+						var parentDescriptor = isDiverging ? $"{rootDescriptor}^{i + 1}" : rootDescriptor;
+						var parentHeightSinceBranch = isDiverging ? 0 : heightSinceBranch + 1;
+						// Stryker restore all
+
+						toVisit.Push((parents[i], height + 1, parentDescriptor, parentHeightSinceBranch));
 					}
 				}
 			}
 
-			Debug.Assert(candidates.Count > 0);
+			Debug.Assert(candidates.Count != 0);
 
 			return candidates
 				.OrderByDescending(x => x.version is not null)