From 22502d7769e28d5a75a9351c1d2a4c86a1f808bd Mon Sep 17 00:00:00 2001 From: Johno Crawford Date: Wed, 5 Feb 2020 10:52:01 +0100 Subject: [PATCH] Support for OpenSslEngine with no finalizer Motivation: Custom SslContext should be retained on init. Modification: Retain custom SslContext. Result: Externally managed SslContext refcount is managed correctly. --- .../org/asynchttpclient/netty/ssl/DefaultSslEngineFactory.java | 1 + 1 file changed, 1 insertion(+) diff --git a/client/src/main/java/org/asynchttpclient/netty/ssl/DefaultSslEngineFactory.java b/client/src/main/java/org/asynchttpclient/netty/ssl/DefaultSslEngineFactory.java index 401c60a581..f2b80bf37e 100644 --- a/client/src/main/java/org/asynchttpclient/netty/ssl/DefaultSslEngineFactory.java +++ b/client/src/main/java/org/asynchttpclient/netty/ssl/DefaultSslEngineFactory.java @@ -34,6 +34,7 @@ public class DefaultSslEngineFactory extends SslEngineFactoryBase { private SslContext buildSslContext(AsyncHttpClientConfig config) throws SSLException { if (config.getSslContext() != null) { + ReferenceCountUtil.retain(config.getSslContext()); return config.getSslContext(); }