fix(Build): harden CI package and public API gates

Author: qinware

engineering/check-public-api.sh

@@ -7,7 +7,17 @@ output_file="$output_dir/public-api.txt"
 
 mkdir -p "$output_dir"
 
-if ! rg -n '^[[:space:]]*public[[:space:]]+((abstract|sealed|static|partial|readonly|record)[[:space:]]+)*(class|interface|enum|struct|record|delegate)[[:space:]]+' src --glob '*.cs' > "$output_file"; then
+public_api_pattern='^[[:space:]]*public[[:space:]]+((abstract|sealed|static|partial|readonly|record)[[:space:]]+)*(class|interface|enum|struct|record|delegate)[[:space:]]+'
+
+if command -v rg >/dev/null 2>&1; then
+  public_api_found=true
+  rg -n "$public_api_pattern" src --glob '*.cs' > "$output_file" || public_api_found=false
+else
+  public_api_found=true
+  find src -name '*.cs' -print0 | xargs -0 grep -nE "$public_api_pattern" > "$output_file" || public_api_found=false
+fi
+
+if [[ "$public_api_found" != true ]]; then
   printf 'No public API declarations found.\n' >&2
   exit 1
 fi

engineering/pack.sh

@@ -26,6 +26,7 @@ mkdir -p "$package_output"
 
 while IFS= read -r project; do
   if [[ "$no_build" == true ]]; then
+    dotnet restore "$project" -p:Configuration="$configuration"
     dotnet pack "$project" --configuration "$configuration" --output "$package_output" --no-build -p:TreatWarningsAsErrors=true
   else
     dotnet pack "$project" --configuration "$configuration" --output "$package_output" -p:TreatWarningsAsErrors=true

tests/AtomUI.City.Build.Tests/EngineeringGateTests.cs

@@ -122,6 +122,34 @@ public void PackScriptTreatsWarningsAsErrors()
         Assert.Contains("-p:TreatWarningsAsErrors=true", script, StringComparison.Ordinal);
     }
 
+    [Fact]
+    public void PackScriptRestoresSelectedConfigurationBeforeNoBuildPack()
+    {
+        var repositoryRoot = RepositoryPaths.FindRepositoryRoot();
+        var scriptPath = Path.Combine(repositoryRoot, EngineeringScriptsDirectoryName, "pack.sh");
+
+        Assert.True(File.Exists(scriptPath), "Expected package script at engineering/pack.sh.");
+
+        var script = File.ReadAllText(scriptPath);
+
+        Assert.Contains("dotnet restore \"$project\" -p:Configuration=\"$configuration\"", script, StringComparison.Ordinal);
+    }
+
+    [Fact]
+    public void PublicApiScriptFallsBackWhenRipgrepIsUnavailable()
+    {
+        var repositoryRoot = RepositoryPaths.FindRepositoryRoot();
+        var scriptPath = Path.Combine(repositoryRoot, EngineeringScriptsDirectoryName, "check-public-api.sh");
+
+        Assert.True(File.Exists(scriptPath), "Expected public API check script at engineering/check-public-api.sh.");
+
+        var script = File.ReadAllText(scriptPath);
+
+        Assert.Contains("command -v rg", script, StringComparison.Ordinal);
+        Assert.Contains("find src -name '*.cs' -print0", script, StringComparison.Ordinal);
+        Assert.Contains("xargs -0 grep", script, StringComparison.Ordinal);
+    }
+
     [Fact]
     public void CSharpSourceFilesDoNotUseRepositoryLicenseHeaders()
     {