Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positives with then→than #720

Closed
hippietrail opened this issue Feb 19, 2025 · 1 comment · Fixed by #735
Closed

False positives with then→than #720

hippietrail opened this issue Feb 19, 2025 · 1 comment · Fixed by #735
Labels
bug Something isn't working

Comments

@hippietrail
Copy link
Contributor

hippietrail commented Feb 19, 2025 •
edited
Loading

Describe the bug
In some contexts a correct "then" is flagged and incorrect "than" is suggested.

To Reproduce
Steps to reproduce the behavior:

  1. Paste in "And if just one of those is set incorrectly or it has the tiniest bit of dirt inside then that will wreak havoc with the engine's running ability."
  2. Notice that this "then" connects a consequence of an earlier "if" with a result.
  3. Hover over the flagged "then" and see it wants to replace it with "than", which won't make sense in this context.
  4. Another example is "So let’s check it out then."

Expected behavior
No error flagged.

Screenshots
Image
Image

Image Image

Platform
VS Code, Windsurf
@hippietrail hippietrail added the bug Something isn't working label Feb 19, 2025
@hippietrail hippietrail changed the title False positive with then→than False positives with then→than Feb 19, 2025
@elijah-potter elijah-potter mentioned this issue Feb 21, 2025
Merged
@hippietrail
Copy link
Contributor Author

hippietrail commented Feb 22, 2025 •
edited
Loading

I seem to still be getting these:

ImageImage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): address edge cases in ThenThan rule Automattic/harper
1 participant
@hippietrail