Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: false positive with some adjacent pairs of pronouns #724

Open
hippietrail opened this issue Feb 19, 2025 · 2 comments
Open

bug: false positive with some adjacent pairs of pronouns #724

hippietrail opened this issue Feb 19, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@hippietrail
Copy link
Contributor

Describe the bug
There's a linting rule against two pronouns next to each other. But sometimes it's perfectly good English.
More subtle rules or heuristics are needed for the lint.

To Reproduce
Steps to reproduce the behavior:

  1. Type/paste in "One told me they were able to begin reading"
  2. Notice "me they" is flagged even though nothing is wrong.

Expected behavior
Nothing flagged in this sentence.

Screenshots
Image
Image

Platform
Windsurf (VS Code)

Additional context
Add any other context about the problem here.

@hippietrail hippietrail added the bug Something isn't working label Feb 19, 2025
@elijah-potter
Copy link
Collaborator

I'd like to push back a little bit. In this case, I'd say you're actually missing a word in the middle. We might want to add an additional suggestion here.

Something more correct would be: "One told me that they were able to begin reading."

@hippietrail
Copy link
Contributor Author

hippietrail commented Feb 21, 2025

I'd like to push back a little bit. In this case, I'd say you're actually missing a word in the middle. We might want to add an additional suggestion here.

Something more correct would be: "One told me that they were able to begin reading."

Actually both are correct. I wonder if any style guides actually insist on adding "that". I'll see what I can find.

I only read a part of the British Council one but it seems this is a grammar point that has received a ton of attention. That page sums it up like this:

Omitting the relative pronoun
Sometimes we can leave out the relative pronoun. For example, we can usually leave out who, which or that if it is followed by a subject.

The assistant [that] we met was really kind.
(we = subject, can omit that)

We can't usually leave it out if it is followed by a verb.

The assistant that helped us was really kind.
(helped = verb, can't omit that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants