Forms: componentize more response fields #45918

simison · 2025-11-13T11:19:39Z

Part of FORMS-391

Proposed changes:

Componentize field image select and slightly update its CSS to better account for long labels; previously these were cutting out when too long, now they go to multiple lines.
Componentize field email
Update slightly flag CSS for the IP

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Create form with email and image select
Submit form and see the result in inbox

github-actions · 2025-11-13T11:20:32Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-country-flag-css-rename branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-country-flag-css-rename

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-11-13T11:20:43Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

simison · 2025-11-13T11:20:51Z

projects/packages/forms/src/dashboard/inbox/dataviews/index.js

 					return (
 						<>
-							<span className="response-country-flag">
+							<span className="jp-forms__inbox-response-country-flag">


Could drop response out of CSS style since it's used here in the row as well, and perhaps componentize the whole thing further.

simison · 2025-11-13T11:22:02Z

projects/packages/forms/src/dashboard/components/response-view/field-image-select/style.scss

+
+.jp-forms__inbox-response-image-select {
+
+	.image-select-field-button {


TODO; remove the wrapper selector and just focus on this single selector to simplify.

jp-launch-control · 2025-11-13T11:29:26Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/dashboard/components/response-view/body.tsx	0/91 (0.00%)	0.00%	-3 💚

2 files are newly checked for coverage.

File	Coverage
projects/packages/forms/src/dashboard/components/response-view/field-email/index.tsx	0/2 (0.00%) 💔
projects/packages/forms/src/dashboard/components/response-view/field-image-select/index.tsx	0/5 (0.00%) 💔

Full summary · PHP report · JS report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

simison · 2025-11-14T16:47:44Z

projects/packages/forms/src/dashboard/components/response-view/field-image-select/style.scss

+	text-align: left;
+	text-wrap: auto;


These two lines are new, and otherwise the CSS classes just got new structure.

They help better account for long labels; previously these were cutting out when too long, now they go to multiple lines.

simison · 2025-11-14T16:48:12Z

projects/packages/forms/src/dashboard/components/response-view/body.tsx

 		// Phone numbers
 		if ( isLikelyPhoneNumber( value ) ) {
-			return (
-				<div className="phone-field">


CSS class was unused so removed it.

github-actions bot added [Feature] Contact Form [Package] Forms [Status] In Progress labels Nov 13, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 13, 2025

simison commented Nov 13, 2025

View reviewed changes

simison force-pushed the update/forms-country-flag-css-rename branch from ec08c3b to 5a16464 Compare November 14, 2025 08:42

simison added 5 commits November 14, 2025 13:36

Forms: update CSS class for IP-flag to be less generic

dab7ddc

changelog

4398546

Forms: componentize more response styles and JS

be314ab

changelog

8f14427

Improve styling for field-image-select

ed2ed07

simison force-pushed the update/forms-country-flag-css-rename branch from 5a16464 to ed2ed07 Compare November 14, 2025 12:07

simison marked this pull request as ready for review November 14, 2025 16:45

simison added [Status] Needs Review This PR is ready for review. [Type] Janitorial and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Nov 14, 2025

simison requested a review from a team November 14, 2025 16:45

simison added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Nov 14, 2025

simison commented Nov 14, 2025

View reviewed changes

simison changed the title ~~Forms: componentize more response styles and JS~~ Forms: componentize more response field styles and JS Nov 14, 2025

simison changed the title ~~Forms: componentize more response field styles and JS~~ Forms: componentize more response fields Nov 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: componentize more response fields #45918

Forms: componentize more response fields #45918

simison commented Nov 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 13, 2025 •

edited

Loading

Uh oh!

simison Nov 13, 2025

Uh oh!

simison Nov 13, 2025

Uh oh!

jp-launch-control bot commented Nov 13, 2025 •

edited

Loading

Uh oh!

simison Nov 14, 2025 •

edited

Loading

Uh oh!

simison Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		.jp-forms__inbox-response-image-select {

		.image-select-field-button {

Forms: componentize more response fields #45918

Are you sure you want to change the base?

Forms: componentize more response fields #45918

Conversation

simison commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simison Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

simison Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

jp-launch-control bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

simison Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simison Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

simison commented Nov 13, 2025 •

edited

Loading

github-actions bot commented Nov 13, 2025 •

edited

Loading

github-actions bot commented Nov 13, 2025 •

edited

Loading

jp-launch-control bot commented Nov 13, 2025 •

edited

Loading

simison Nov 14, 2025 •

edited

Loading