Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank Canvas 3: Reconsider the Font Scale #6721

Closed
iamtakashi opened this issue Nov 10, 2022 · 6 comments
Closed

Blank Canvas 3: Reconsider the Font Scale #6721

iamtakashi opened this issue Nov 10, 2022 · 6 comments
Labels
Needs triage [Type] Bug Something isn't working

Comments

@iamtakashi
Copy link
Contributor

iamtakashi commented Nov 10, 2022

Quick summary

Hi, this is not a bug report but more of a suggestion.

We could give a little more contrast in sizes in Blank Canvas 3. Especially between small and medium.

"fontSizes": [

Context: @alaczek and I noticed a pattern using the Pattern Assembler doesn't quite have a good contrast in the scale. This pattern uses small and medium, but as you can see, they are very similar.

image

Steps to reproduce

Test Pattern Assembler pbxlJb-2wa-p2

What you expected to happen

They should have a better font scale that has good contrast in sizes.

What actually happened

The small and medium sizes have very little contrast in size.

@iamtakashi iamtakashi added [Type] Bug Something isn't working Needs triage labels Nov 10, 2022
@iamtakashi
Copy link
Contributor Author

Forgot ping. @onuro

@onuro
Copy link
Contributor

onuro commented Nov 15, 2022

@iamtakashi I agree. The medium and small sizes are copied from TT3 being unchanged. I'm testing 2 options:

1. Medium max(fluid) font size to be 1.25rem instead of 1.125:

image

In the BC3 the default text size is also medium.

2. Medium font size to be unchanged but less "small" size:

image

What do you think?

@iamtakashi
Copy link
Contributor Author

  1. Medium font size to be unchanged but less "small" size:

What's the max size of small in this case?

@onuro
Copy link
Contributor

onuro commented Nov 17, 2022

What's the max size of small in this case?

Min 0.875rem and max 1rem

@richtabor
Copy link
Contributor

@iamtakashi is this still relevant? Thanks!

@iamtakashi
Copy link
Contributor Author

@richtabor I don't think so. I'm closing the issue but reopen it if it needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants