Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove statement descriptor fields from Settings page in favour of Account Management embedded component #10392

Open
mordeth opened this issue Feb 17, 2025 · 3 comments · May be fixed by #10367
Assignees
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. component: accounts Issues related to Accounts component: settings Issues related to Settings focus: account lifecycle type: enhancement The issue is a request for an enhancement.

Comments

@mordeth
Copy link
Contributor

mordeth commented Feb 17, 2025

Description

This issue is a follow-up to #9129, where we introduced the embedded Account Management component, resulting in a duplicate statement descriptor field. To prevent this duplication, the setting needs to be removed.

For Japanese accounts, we currently display two additional statement descriptor fields in Kanji and Kana, which should also be removed.

Additionally, if the support phone and support email settings are later introduced within the Account Management component, they will need to be removed from the settings as well.

Acceptance criteria

  • The statement descriptor settings field is removed.
  • For Japanese accounts, the two additional statement descriptor fields (Kanji and Kana) are also removed.
  • Optionally remove support phone and support email.
@mordeth mordeth self-assigned this Feb 17, 2025
@mordeth mordeth added category: projects For any issues which are part of any project, including bugs, enhancements, etc. component: accounts Issues related to Accounts component: settings Issues related to Settings focus: account lifecycle type: enhancement The issue is a request for an enhancement. labels Feb 17, 2025
@mordeth mordeth linked a pull request Feb 17, 2025 that will close this issue
6 tasks
@aheckler
Copy link
Member

Additionally, if the support phone and support email settings are later introduced within the Account Management component, they will need to be removed from the settings as well.

If we want to remove the support phone and support email fields from the "native" WooPayments settings and instead rely on the account mgmt component, we'll need to make sure:

  • That the support phone and support email fields are shown for ALL WooPayments accounts. I believe @oaratovskyi has been testing this lately and it's been inconsistent at best. :(
  • We'll also need to make sure we can REQUIRE the support phone field to be filled out, as we do now with the "native" field. (See image below.) This is because, if we cannot mark the support phone field as required, merchants are more likely to avoid filling it out, causing increased support burden for us: pbUcTB-5ch-p2.

Image

@mordeth
Copy link
Contributor Author

mordeth commented Feb 18, 2025

Great point, @aheckler! In my latest tests, the support phone field consistently appears for all countries except Japan and Singapore. Ideally, we should have control over which fields are displayed in the Account Management component to avoid duplication and ensure a more consistent experience.

@oaratovskyi
Copy link
Contributor

oaratovskyi commented Feb 18, 2025

@aheckler very good points! I believe it would be simpler to keep this logic (support phone number) on our side and ask Stripe to remove it from the embedded components for us if they can't comply with the logic that we want (make them required and show it in any case).

The account management component is on hold now paJDYF-gx8-p2#comment-28053, we are waiting to hear back from Stripe p1739557944477869/1738249710.124389-slack-C9976E5MJ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. component: accounts Issues related to Accounts component: settings Issues related to Settings focus: account lifecycle type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants