Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an ability to control Windows rounded corners behavior #17294

Open
BAndysc opened this issue Oct 16, 2024 · 1 comment · May be fixed by #17354
Open

Add an ability to control Windows rounded corners behavior #17294

BAndysc opened this issue Oct 16, 2024 · 1 comment · May be fixed by #17354
Labels
enhancement os-windows

Comments

@BAndysc
Copy link
Contributor

BAndysc commented Oct 16, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

On Windows, rounded corners are currently requested at this location:

Avalonia/src/Windows/Avalonia.Win32/WindowImpl.cs

Lines 1157 to 1158 in 58de42b

int cornerPreference = (int)DwmWindowCornerPreference.DWMWCP_ROUND;
DwmSetWindowAttribute(_hwnd, (int)DwmWindowAttribute.DWMWA_WINDOW_CORNER_PREFERENCE, &cornerPreference, sizeof(int));

However, to maintain the aesthetic of the Classic theme, DWMWCP_DONOTROUND should be applied instead. I would still like to use SystemDecorations=Full to retain TitleBar dragging and window resizing functionality.

Describe the solution you'd like

Introducing a new StyledProperty PreferRoundedCorners on the Window could handle this, allowing flexibility within this method.

Describe alternatives you've considered

While I can manually call DwmSetWindowAttribute in the ExtendClientAreaToDecorationsChanged event, having a dedicated property would make it simpler.

Additional context

No response
@thevortexcloud
Copy link
Contributor

PreferRoundedCorners

It should probably follow the current hint pattern to indicate it may not work/do anything.

This was referenced Oct 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement os-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add WindowCornerHintsProperty BAndysc/Avalonia
3 participants
@BAndysc @timunie @thevortexcloud