Skip to content

Commit 8e6b0a7

Browse files
chenliang613ravipesala
authored andcommitted
[CARBONDATA-1599] Update pull request checklist
Remove title and description items from pull request checklist, add them to How to contribute document This closes apache#1451
1 parent 5936e7f commit 8e6b0a7

File tree

2 files changed

+10
-16
lines changed

2 files changed

+10
-16
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+4-14
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,5 @@
1-
Be sure to do all of the following to help us incorporate your contribution
2-
quickly and easily:
3-
4-
- [ ] Make sure the PR title is formatted like:
5-
`[CARBONDATA-<Jira issue #>] Description of pull request`
6-
7-
- [ ] Make sure to add PR description including
8-
9-
- the root cause/problem statement
10-
- What is the implemented solution
1+
Be sure to do all of the following checklist to help us incorporate
2+
your contribution quickly and easily:
113

124
- [ ] Any interfaces changed?
135

@@ -16,13 +8,11 @@ quickly and easily:
168
- [ ] Document update required?
179

1810
- [ ] Testing done
19-
2011
Please provide details on
2112
- Whether new unit test cases have been added or why no new tests are required?
2213
- How it is tested? Please attach test report.
2314
- Is it a performance related change? Please attach the performance test report.
2415
- Any additional information to help reviewers in testing this change.
25-
16+
2617
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
27-
28-
---
18+

docs/How-to-contribute-to-Apache-CarbonData.md

+6-2
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,13 @@ $ git rebase -i origin/master
152152
Navigate to the CarbonData GitHub mirror to create a pull request. The title of the pull request
153153
should be strictly in the following format:
154154
```
155-
[CARBONDATA-issue number>] Title of the pull request
155+
[CARBONDATA-JiraTicketNumer][FeatureName] Description of pull request
156156
```
157-
Please include a descriptive pull request message to help make the reviewer’s job easier.
157+
Please include a descriptive pull request message to help make the reviewer’s job easier:
158+
```
159+
- The root cause/problem statement
160+
- What is the implemented solution
161+
```
158162

159163
If you know a good committer to review your pull request, please make a comment like the following.
160164
If not, don’t worry, a committer will pick it up.

0 commit comments

Comments
 (0)