[CARBONDATA-1326] Fixed normal/low priority findbug issues

This closes apache#1204

Author: dhatchayani

core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java

@@ -186,10 +186,6 @@ public final class CarbonCommonConstants {
   public static final byte[] MEMBER_DEFAULT_VAL_ARRAY =
       MEMBER_DEFAULT_VAL.getBytes(Charset.forName(DEFAULT_CHARSET));
 
-  /**
-   * Bytes for string 0, it is used in codegen in case of null values.
-   */
-  public static final byte[] ZERO_BYTE_ARRAY = "0".getBytes();
   /**
    * FILE STATUS IN-PROGRESS
    */
@@ -963,12 +959,12 @@ public final class CarbonCommonConstants {
   /**
    * If the level 2 compaction is done in minor then new compacted segment will end with .2
    */
-  public static String LEVEL2_COMPACTION_INDEX = ".2";
+  public static final String LEVEL2_COMPACTION_INDEX = ".2";
 
   /**
    * Indicates compaction
    */
-  public static String COMPACTION_KEY_WORD = "COMPACTION";
+  public static final String COMPACTION_KEY_WORD = "COMPACTION";
 
   /**
    * hdfs temporary directory key
@@ -985,30 +981,30 @@ public final class CarbonCommonConstants {
   /**
    * File created in case of minor compaction request
    */
-  public static String minorCompactionRequiredFile = "compactionRequired_minor";
+  public static final String minorCompactionRequiredFile = "compactionRequired_minor";
 
   /**
    * File created in case of major compaction request
    */
-  public static String majorCompactionRequiredFile = "compactionRequired_major";
+  public static final String majorCompactionRequiredFile = "compactionRequired_major";
 
   /**
    * @Deprecated : This property has been deprecated.
    * Property for enabling system level compaction lock.1 compaction can run at once.
    */
   @CarbonProperty
-  public static String ENABLE_CONCURRENT_COMPACTION = "carbon.concurrent.compaction";
+  public static final String ENABLE_CONCURRENT_COMPACTION = "carbon.concurrent.compaction";
 
   /**
    * Default value of Property for enabling system level compaction lock.1 compaction can run
    * at once.
    */
-  public static String DEFAULT_ENABLE_CONCURRENT_COMPACTION = "true";
+  public static final String DEFAULT_ENABLE_CONCURRENT_COMPACTION = "true";
 
   /**
    * Compaction system level lock folder.
    */
-  public static String SYSTEM_LEVEL_COMPACTION_LOCK_FOLDER = "SystemCompactionLock";
+  public static final String SYSTEM_LEVEL_COMPACTION_LOCK_FOLDER = "SystemCompactionLock";
 
   /**
    * This batch size is used to send rows from load step to another step in batches.
@@ -1048,34 +1044,34 @@ public final class CarbonCommonConstants {
   /**
    * columns which gets updated in update will have header ends with this extension.
    */
-  public static String UPDATED_COL_EXTENSION = "-updatedColumn";
+  public static final String UPDATED_COL_EXTENSION = "-updatedColumn";
 
   /**
    * appending the key to differentiate the update flow with insert flow.
    */
-  public static String RDDUTIL_UPDATE_KEY = "UPDATE_";
+  public static final String RDDUTIL_UPDATE_KEY = "UPDATE_";
 
   /**
    * to determine to use the rdd persist or not.
    */
   @CarbonProperty
-  public static String isPersistEnabled = "carbon.update.persist.enable";
+  public static final String isPersistEnabled = "carbon.update.persist.enable";
 
   /**
    * for enabling or disabling Horizontal Compaction.
    */
   @CarbonProperty
-  public static String isHorizontalCompactionEnabled = "carbon.horizontal.compaction.enable";
+  public static final String isHorizontalCompactionEnabled = "carbon.horizontal.compaction.enable";
 
   /**
    * Default value for HorizontalCompaction is true.
    */
-  public static String defaultIsHorizontalCompactionEnabled = "true";
+  public static final String defaultIsHorizontalCompactionEnabled = "true";
 
   /**
    * by default rdd will be persisted in the update case.
    */
-  public static String defaultValueIsPersistEnabled = "true";
+  public static final String defaultValueIsPersistEnabled = "true";
 
   /**
    * current data file version
@@ -1089,7 +1085,7 @@ public final class CarbonCommonConstants {
   /**
    * Maximum no of column supported
    */
-  public static int DEFAULT_MAX_NUMBER_OF_COLUMNS = 20000;
+  public static final int DEFAULT_MAX_NUMBER_OF_COLUMNS = 20000;
 
   /**
    * Maximum waiting time (in seconds) for a query for requested executors to be started

core/src/main/java/org/apache/carbondata/core/keygenerator/KeyGenerator.java

@@ -89,15 +89,6 @@ public interface KeyGenerator extends Serializable, Comparator<byte[]> {
    */
   int getKeySizeInBytes();
 
-  /**
-   * It gets the specified index and size from the single key aka byte aray
-   *
-   * @param key
-   * @param index
-   * @param size
-   * @return
-   */
-  long[] getSubKeyArray(byte[] key, int index, int size);
 
   /**
    * returns key bytes offset

core/src/main/java/org/apache/carbondata/core/keygenerator/mdkey/AbstractKeyGenerator.java

@@ -66,10 +66,6 @@ public int compare(byte[] buffer1, int offset1, int length1, byte[] buffer2, int
     return 0;
   }
 
-  @Override public int[] getKeyByteOffsets(int index) {
-    return null;
-  }
-
   @Override public int getDimCount() {
     return 0;
   }

core/src/main/java/org/apache/carbondata/core/keygenerator/mdkey/MultiDimKeyVarLengthGenerator.java

@@ -66,16 +66,6 @@ public int getKeySizeInBytes() {
     return bits.getByteSize();
   }
 
-  @Override public long[] getSubKeyArray(byte[] key, int index, int size) {
-    if (index < 0 || size == 0) {
-      return null;
-    }
-    long[] keys = bits.getKeyArray(key, 0);
-    long[] rtn = new long[size];
-    System.arraycopy(keys, index, rtn, 0, size);
-    return rtn;
-  }
-
   @Override public int[] getKeyByteOffsets(int index) {
     return byteRangesForKeys[index];
   }

core/src/main/java/org/apache/carbondata/core/locks/CarbonLockFactory.java

@@ -52,7 +52,7 @@ public class CarbonLockFactory {
    */
   public static ICarbonLock getCarbonLockObj(CarbonTableIdentifier tableIdentifier,
       String lockFile) {
-    switch (lockTypeConfigured.toUpperCase()) {
+    switch (lockTypeConfigured) {
       case CarbonCommonConstants.CARBON_LOCK_TYPE_LOCAL:
         return new LocalFileLock(tableIdentifier, lockFile);
 
@@ -74,7 +74,7 @@ public static ICarbonLock getCarbonLockObj(CarbonTableIdentifier tableIdentifier
    * @return carbon lock
    */
   public static ICarbonLock getCarbonLockObj(String locFileLocation, String lockFile) {
-    switch (lockTypeConfigured.toUpperCase()) {
+    switch (lockTypeConfigured) {
       case CarbonCommonConstants.CARBON_LOCK_TYPE_LOCAL:
         return new LocalFileLock(locFileLocation, lockFile);
 
@@ -94,7 +94,8 @@ public static ICarbonLock getCarbonLockObj(String locFileLocation, String lockFi
    */
   private static void getLockTypeConfigured() {
     lockTypeConfigured = CarbonProperties.getInstance()
-        .getProperty(CarbonCommonConstants.LOCK_TYPE, CarbonCommonConstants.LOCK_TYPE_DEFAULT);
+        .getProperty(CarbonCommonConstants.LOCK_TYPE, CarbonCommonConstants.LOCK_TYPE_DEFAULT)
+        .toUpperCase();
     LOGGER.info("Configured lock type is: " + lockTypeConfigured);
   }
 

core/src/main/java/org/apache/carbondata/core/metadata/CarbonTableIdentifier.java

@@ -25,6 +25,8 @@
  */
 public class CarbonTableIdentifier implements Serializable {
 
+  private static final long serialVersionUID = -0L;
+
   /**
    * database name
    */

core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java

@@ -29,6 +29,8 @@
  */
 public class ValueEncoderMeta implements Serializable {
 
+  private static final long serialVersionUID = -0L;
+
   /**
    * maxValue
    */

core/src/main/java/org/apache/carbondata/core/metadata/schema/BucketingInfo.java

@@ -27,6 +27,8 @@
  */
 public class BucketingInfo implements Serializable {
 
+  private static final long serialVersionUID = -0L;
+
   private List<ColumnSchema> listOfColumns;
 
   private int numberOfBuckets;

core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java

@@ -29,6 +29,8 @@
  */
 public class PartitionInfo implements Serializable {
 
+  private static final long serialVersionUID = -0L;
+
   private List<ColumnSchema> columnSchemaList;
 
   private PartitionType partitionType;

core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java

@@ -185,18 +185,14 @@ public void setStorePath(String storePath) {
       return false;
     }
     TableInfo other = (TableInfo) obj;
-    if (databaseName == null) {
-      if (other.databaseName != null) {
-        return false;
-      }
-    } else if (!tableUniqueName.equals(other.tableUniqueName)) {
+    if ((databaseName == null && other.databaseName != null) || (databaseName != null
+        && other.databaseName == null)) {
       return false;
     }
 
-    if (tableUniqueName == null) {
-      if (other.tableUniqueName != null) {
-        return false;
-      }
+    if ((tableUniqueName == null && other.tableUniqueName != null) || (tableUniqueName != null
+        && other.tableUniqueName == null)) {
+      return false;
     } else if (!tableUniqueName.equals(other.tableUniqueName)) {
       return false;
     }

core/src/main/java/org/apache/carbondata/core/scan/expression/ExpressionResult.java

@@ -187,7 +187,7 @@ public String getString() throws FilterIllegalMemberException {
             }
             return parser.format(new Timestamp((long) value));
           } else if (value instanceof Integer) {
-            return parser.format(new java.sql.Date((int)value));
+            return parser.format(new java.sql.Date((long)value));
           }
           return value.toString();
         default:
@@ -308,7 +308,6 @@ public BigDecimal getDecimal() throws FilterIllegalMemberException {
         case LONG:
           return new BigDecimal((long) value);
         case DOUBLE:
-          return new BigDecimal(value.toString());
         case DECIMAL:
           return new BigDecimal(value.toString());
         case DATE:
@@ -546,7 +545,9 @@ public boolean isNull() {
         default:
           return this.getString().compareTo(o.getString());
       }
-    } catch (Exception e) {
+    } catch (ParseException e) {
+      return -1;
+    } catch (FilterIllegalMemberException e) {
       return -1;
     }
   }

core/src/main/java/org/apache/carbondata/core/scan/expression/RangeExpressionEvaluator.java

@@ -120,8 +120,8 @@ public void replaceWithRangeExpression(
 
         for (FilterModificationNode exp : filterExp) {
           if ((exp.getExpType() == GREATERTHAN) || (exp.getExpType() == GREATERTHAN_EQUALTO)) {
-            if ((null == endMax) || ((null != endMax) && (checkLiteralValue(exp.getCurrentExp(),
-                endMax.getCurrentExp())))) {
+            if ((null == endMax) || checkLiteralValue(exp.getCurrentExp(),
+                endMax.getCurrentExp())) {
               if (null == startMin) {
                 startMin = exp;
               } else {
@@ -141,8 +141,8 @@ public void replaceWithRangeExpression(
             }
           }
           if ((exp.getExpType() == LESSTHAN) || (exp.getExpType() == LESSTHAN_EQUALTO)) {
-            if ((null == startMin) || ((null != startMin) && (checkLiteralValue(exp.getCurrentExp(),
-                startMin.getCurrentExp())))) {
+            if ((null == startMin) || checkLiteralValue(exp.getCurrentExp(),
+                startMin.getCurrentExp())) {
               if (null == endMax) {
                 endMax = exp;
               } else {
@@ -411,10 +411,10 @@ private Expression traverseTree(Expression currentNode, Expression parentNode) {
       ExpressionType srcExpType = getExpressionType(this.getSrcNode());
       ExpressionType tarExpType = getExpressionType(currentNode);
 
-      if ((null != srcColumnName) && (null != tarColumnName) && (srcColumnName == tarColumnName)
-          && (srcExpType != ExpressionType.FALSE) && (tarExpType != ExpressionType.FALSE) && (
-          (matchExpType(srcExpType, tarExpType)) && checkLiteralValue(this.getSrcNode(),
-              currentNode))) {
+      if ((null != srcColumnName) && (null != tarColumnName) && (srcColumnName
+          .equals(tarColumnName)) && (srcExpType != ExpressionType.FALSE) && (tarExpType
+          != ExpressionType.FALSE) && ((matchExpType(srcExpType, tarExpType)) && checkLiteralValue(
+          this.getSrcNode(), currentNode))) {
         this.setTarNode(currentNode);
         this.setTarParentNode(parentNode);
         return parentNode;

core/src/main/java/org/apache/carbondata/core/scan/filter/FilterExpressionProcessor.java

@@ -357,11 +357,6 @@ private FilterResolverIntf createFilterResolverTree(Expression expressionTree,
     BinaryExpression currentExpression = null;
     switch (filterExpressionType) {
       case OR:
-        currentExpression = (BinaryExpression) expressionTree;
-        return new LogicalFilterResolverImpl(
-            createFilterResolverTree(currentExpression.getLeft(), tableIdentifier),
-            createFilterResolverTree(currentExpression.getRight(), tableIdentifier),
-            currentExpression);
       case AND:
         currentExpression = (BinaryExpression) expressionTree;
         return new LogicalFilterResolverImpl(

core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java

@@ -21,6 +21,7 @@
 import java.math.BigDecimal;
 import java.nio.ByteBuffer;
 import java.nio.charset.Charset;
+import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -322,7 +323,8 @@ public static boolean checkIfLeftExpressionRequireEvaluation(Expression expressi
    * @return
    */
   public static boolean checkIfDataTypeNotTimeStamp(Expression expression) {
-    if (expression.getFilterExpressionType() == ExpressionType.LITERAL) {
+    if (expression.getFilterExpressionType() == ExpressionType.LITERAL
+        && expression instanceof LiteralExpression) {
       DataType dataType = ((LiteralExpression) expression).getLiteralExpDataType();
       if (!(dataType == DataType.TIMESTAMP || dataType == DataType.DATE)) {
         return true;
@@ -1288,7 +1290,9 @@ public static int compareFilterKeyBasedOnDataType(String dictionaryVal, String m
         default:
           return -1;
       }
-    } catch (Exception e) {
+    } catch (ParseException e) {
+      return -1;
+    } catch (NumberFormatException e) {
       return -1;
     }
   }
@@ -1361,8 +1365,7 @@ public static void traverseResolverTreeAndGetStartAndEndKey(SegmentProperties se
     if (segmentProperties.getNumberOfNoDictSortColumns() == 0) {
       listOfStartKeyByteArray = new ArrayList<byte[]>();
       listOfEndKeyByteArray = new ArrayList<byte[]>();
-    } else if (segmentProperties.getNumberOfNoDictSortColumns() < listOfStartKeyByteArray
-        .size()) {
+    } else {
       while (segmentProperties.getNumberOfNoDictSortColumns() < listOfStartKeyByteArray.size()) {
         listOfStartKeyByteArray.remove(listOfStartKeyByteArray.size() - 1);
         listOfEndKeyByteArray.remove(listOfEndKeyByteArray.size() - 1);
@@ -1428,7 +1431,9 @@ private static int compareFilterMembersBasedOnActualDataType(String filterMember
         default:
           return filterMember1.compareTo(filterMember2);
       }
-    } catch (Exception e) {
+    } catch (ParseException e) {
+      return -1;
+    } catch (NumberFormatException e) {
       return -1;
     }
   }