Adlsgen2 fixes (#1974)

* Modified create_or_get_group Function. Added the mailEnabled and mailNickname properties.

* Changed  the conditional check in the adlsgen2setup.sh script. The change from -n to -z ensures that the script correctly verifies whether the AZURE_ADLS_GEN2_STORAGE_ACCOUNT environment variable is set and non-empty before proceeding. This is the intended behavior to avoid running the script without the necessary configuration.

* Added a comment to inform the developer to resolve a potential AAD tenant issue in adlsgen2setup.py

Author: john-carroll-sw

scripts/adlsgen2setup.py

@@ -135,8 +135,11 @@ async def create_or_get_group(self, group_name: str):
                 logging.info(f"Could not find group {group_name}, creating...")
                 group = {
                     "displayName": group_name,
-                    "groupTypes": ["Unified"],
                     "securityEnabled": self.security_enabled_groups,
+                    "groupTypes": ["Unified"],
+                    # If Unified does not work for you, then you may need the following settings instead:
+                    # "mailEnabled": False,
+                    # "mailNickname": group_name,
                 }
                 async with session.post("https://graph.microsoft.com/v1.0/groups", json=group) as response:
                     content = await response.json()

scripts/adlsgen2setup.sh

@@ -2,7 +2,7 @@
 
 . ./scripts/loadenv.sh
 
-if [ -n "$AZURE_ADLS_GEN2_STORAGE_ACCOUNT" ]; then
+if [ -z "$AZURE_ADLS_GEN2_STORAGE_ACCOUNT" ]; then
     echo 'AZURE_ADLS_GEN2_STORAGE_ACCOUNT must be set to continue'
     exit 1
 fi