-
Notifications
You must be signed in to change notification settings - Fork 6
Add GitHub Actions workflow for packages-v1 build validation without package-lock.json #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: diberry <[email protected]>
Co-authored-by: diberry <[email protected]>
Co-authored-by: diberry <[email protected]>
| cache: 'npm' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use npm install instead of npm ci because package-lock.json isn't checked in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to npm install in commit cd655de
diberry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the schedule run on sunday night and use npm install instead of npm ci. Resolve any open comments.
Co-authored-by: diberry <[email protected]>
Co-authored-by: diberry <[email protected]>
Both changes completed in commit cd655de:
|
|
@copilot change this file so that it runs without the need for package-lock.json |
Co-authored-by: diberry <[email protected]>
Co-authored-by: diberry <[email protected]>
Purpose
Add CI pipeline to validate builds across Node.js versions for packages-v1 workspace with scheduled weekly runs. The workflow is designed to run completely without package-lock.json dependency.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
npm installfor dependency installationOther Information
Workflow Configuration:
fail-fast: falseensures all Node versions testedneeds: buildand conditional check enforces all-pass requirementworkflow_dispatchavailable for testingnpm installsince package-lock.json is not tracked in the repositorycache: 'npm'removed) to eliminate package-lock.json dependencySecurity:
permissions: contents: readfollows principle of least privilegePackage-lock.json Independence:
npm installOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.