Skip to content

Commit 5a2c91d

Browse files
authored
Some minor refine on the scripts (#185)
## Purpose fix and refinements on scripts ## Does this introduce a breaking change? <!-- Mark one with an "x". --> ``` [ ] Yes [x] No ``` ## Pull Request Type What kind of change does this Pull Request introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [x] Bugfix [ ] Feature [x] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Documentation content changes [ ] Other... Please describe: ```
1 parent 8274587 commit 5a2c91d

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

.devcontainer/postCreateCommand.sh

+4-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@
22

33
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
44

5-
azd config set alpha.deployment.stacks on
5+
CHECK_AZD=$(which azd)
6+
if [[ ! -z "$CHECK_AZD" ]]; then
7+
azd config set alpha.deployment.stacks on
8+
fi
69

710
grep JAVA_AI_FUNC "$HOME/.bashrc" > /dev/null 2>&1
811
if [[ $? -ne 0 ]]; then

docs/04_lab_monitor/0403.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ For additional information on how this works, review:
6868

6969
```bash
7070
export RESOURCE_GROUP APP_INSIGHTS_CONN
71-
../tools/update-apps-appinsights.sh
71+
bash tools/update-apps-appinsights.sh
7272
```
7373

7474
{: .note }
@@ -77,7 +77,7 @@ For additional information on how this works, review:
7777
<details markdown="1">
7878

7979
<summary><b>(Optional)</b> Alternatively, you can manually build each app individually. <a>Click here for instructions on how to do this</a>.</summary>
80-
80+
8181
Run the following commands:
8282

8383
```bash

tools/azure-resource.profile

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ OPEN_AI_SERVICE_NAME=open-ai-account-$UNIQUEID
2727

2828
############### Optional ###############
2929
# Set RUN_OPTIONAL to true if you want to deploy resources for Lab 4 & Lab 5
30-
RUN_OPTIONAL=false
30+
RUN_OPTIONAL=true
3131

3232
# Set the below variables if RUN_OPTIONAL=true
3333

tools/create-azure-resource.sh

+2-3
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ else
2929
--resource-group $RESOURCE_GROUP \
3030
--location $SQL_LOCATION \
3131
--public-access none \
32-
--yes \
33-
--output table
32+
--yes
3433
fi
3534

3635
# Azure Container Registry
@@ -134,7 +133,7 @@ else
134133

135134
az deployment group create \
136135
--resource-group $RESOURCE_GROUP \
137-
--template-file ../infra/bicep/modules/grafana/grafana-dashboard.bicep \
136+
--template-file $DIR/../infra/bicep/modules/grafana/grafana-dashboard.bicep \
138137
--parameters grafanaName=$GRAFANA_NAME location=$GRAFANA_LOCATION \
139138
--output table
140139
fi

0 commit comments

Comments
 (0)