frontend: ci test seems to be flaky

[frzifus]

https://github.com/Azure/ARO-HCP/actions/runs/13010842188/job/36287996416?pr=1132

	github.com/Azure/ARO-HCP/frontend		coverage: 0.0% of statements
	github.com/Azure/ARO-HCP/frontend/pkg/config		coverage: 0.0% of statements
	github.com/Azure/ARO-HCP/frontend/cmd		coverage: 0.0% of statements
	github.com/Azure/ARO-HCP/frontend/utils		coverage: 0.0% of statements
{"time":"2025-01-28T12:54:15.228403686Z","level":"ERROR","msg":"error retrieving value from context, value obtained was '<nil>' and type obtained was '*slog.Logger'"}
{"time":"2025-01-28T12:54:15.228567801Z","level":"INFO","msg":"read request","request_method":"PUT","request_path":"/subscriptions/00000000-0000-0000-0000-000000000000","request_proto":"HTTP/1.1","request_query":"api-version=2.0","request_remote_addr":"127.0.0.1:33948","request_user_agent":"Go-http-client/1.1"}
{"time":"2025-01-28T12:54:15.228606082Z","level":"ERROR","msg":"error retrieving value from context, value obtained was '<nil>' and type obtained was '*slog.Logger'"}
{"time":"2025-01-28T12:54:15.228665262Z","level":"ERROR","msg":"error retrieving value from context, value obtained was '<nil>' and type obtained was '*slog.Logger'"}
{"time":"2025-01-28T12:54:15.228814279Z","level":"ERROR","msg":"error retrieving value from context, value obtained was '<nil>' and type obtained was '*slog.Logger'"}
{"time":"2025-01-28T12:54:15.228823837Z","level":"ERROR","msg":"error retrieving value from context, value obtained was '<nil>' and type obtained was '*slog.Logger'"}
{"time":"2025-01-28T12:54:15.228837633Z","level":"ERROR","msg":"error retrieving value from context, value obtained was '<nil>' and type obtained was '<nil>'","request_id":"f38eaa54-6092-497e-80cb-1ba334486a75","client_request_id":"","correlation_request_id":"","subscription_id":"00000000-0000-0000-0000-000000000000"}
{"time":"2025-01-28T12:54:15.228861758Z","level":"INFO","msg":"unable to retrieve subscription document for the `frontend_requests_total` metric","subscriptionId":"00000000-0000-0000-0000-000000000000","error":"not found"}
{"time":"2025-01-28T12:54:15.22901382Z","level":"INFO","msg":"send response","request_method":"PUT","request_path":"/subscriptions/00000000-0000-0000-0000-000000000000","request_proto":"HTTP/1.1","request_query":"api-version=2.0","request_remote_addr":"127.0.0.1:33948","request_user_agent":"Go-http-client/1.1","body_read_bytes":116,"body_written_bytes":107,"response_status_code":500,"duration":0.000451881}
--- FAIL: TestSubscriptionsPUT (0.01s)
    --- FAIL: TestSubscriptionsPUT/PUT_Subscription_-_Doc_does_not_exist (0.00s)
        frontend_test.go:307: expected status code 200, got 500
        controller.go:97: missing call(s) to *mocks.MockDBClient.CreateSubscriptionDoc(is anything, is anything) /home/runner/work/ARO-HCP/ARO-HCP/frontend/pkg/frontend/frontend_test.go:274
        controller.go:97: aborting test due to missing call(s)
2025/01/28 12:54:15 WARN Failed to parse X-Ms-Arm-Resource-System-Data header: invalid character 'i' looking for beginning of value
2025/01/28 12:54:15 ERROR unsupported subscription state "Invalid"
2025/01/28 12:54:15 ERROR error retrieving value from context, value obtained was '<nil>' and type obtained was '<nil>'
FAIL

[mbarnes]

I've seen these unit test flakes before. It may be a panic being masked by the MiddlewarePanic function.

[mbarnes]

I changed MiddlewarePanic to disable itself when being run through go test. Hopefully this will make the root cause clearer the next time one of us sees it in a CI run.